From: Jonathan Cavitt <jonathan.cavitt@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com,
jonathan.cavitt@intel.com, raag.jadav@intel.com
Subject: [PATCH 4/5] drm/{i915, xe}: Refactor generic_handle_irq_safe() error messages
Date: Sat, 6 Jun 2026 00:04:43 +0800 [thread overview]
Message-ID: <20260605160444.3833295-5-jonathan.cavitt@intel.com> (raw)
In-Reply-To: <20260605160444.3833295-1-jonathan.cavitt@intel.com>
Currently, all but one uses of generic_handle_irq_safe() report error
messages using .*_err_ratelimited() error reporting helper functions.
These helper functions declare their error messages in the following
form:
"error handling [COMPONENT NAME] irq: %d\n"
.*_err_ratelimited() already logs "error" as a part of the error
message, so declaring the error is redundant. Reword it.
v2:
- Use drm_err_ratelimited() correctly (jcavitt)
v3:
- Use xe_err_ratelimited() instead (Jadav)
- Split into patch series (jcavitt)
Suggested-by: Raag Jadav <raag.jadav@intel.com>
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
---
drivers/gpu/drm/i915/display/intel_lpe_audio.c | 2 +-
drivers/gpu/drm/i915/gt/intel_gsc.c | 2 +-
drivers/gpu/drm/xe/xe_heci_gsc.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_lpe_audio.c b/drivers/gpu/drm/i915/display/intel_lpe_audio.c
index 022ad18044bf..e756ed1d1132 100644
--- a/drivers/gpu/drm/i915/display/intel_lpe_audio.c
+++ b/drivers/gpu/drm/i915/display/intel_lpe_audio.c
@@ -265,7 +265,7 @@ void intel_lpe_audio_irq_handler(struct intel_display *display)
ret = generic_handle_irq_safe(display->audio.lpe.irq);
if (ret)
drm_err_ratelimited(display->drm,
- "error handling LPE audio irq: %d\n", ret);
+ "failed to handle LPE audio irq: %d\n", ret);
}
/**
diff --git a/drivers/gpu/drm/i915/gt/intel_gsc.c b/drivers/gpu/drm/i915/gt/intel_gsc.c
index 050d909fb4f8..c2d76b0bc5fe 100644
--- a/drivers/gpu/drm/i915/gt/intel_gsc.c
+++ b/drivers/gpu/drm/i915/gt/intel_gsc.c
@@ -286,7 +286,7 @@ static void gsc_irq_handler(struct intel_gt *gt, unsigned int intf_id)
ret = generic_handle_irq_safe(gt->gsc.intf[intf_id].irq);
if (ret)
- gt_err_ratelimited(gt, "error handling GSC irq: %d\n", ret);
+ gt_err_ratelimited(gt, "failed to handle GSC irq: %d\n", ret);
}
void intel_gsc_irq_handler(struct intel_gt *gt, u32 iir)
diff --git a/drivers/gpu/drm/xe/xe_heci_gsc.c b/drivers/gpu/drm/xe/xe_heci_gsc.c
index d716371fbbe9..477004058834 100644
--- a/drivers/gpu/drm/xe/xe_heci_gsc.c
+++ b/drivers/gpu/drm/xe/xe_heci_gsc.c
@@ -223,7 +223,7 @@ void xe_heci_gsc_irq_handler(struct xe_device *xe, u32 iir)
ret = generic_handle_irq_safe(xe->heci_gsc.irq);
if (ret)
- xe_err_ratelimited(xe, "error handling GSC irq: %d\n", ret);
+ xe_err_ratelimited(xe, "failed to handle GSC irq: %d\n", ret);
}
void xe_heci_csc_irq_handler(struct xe_device *xe, u32 iir)
@@ -243,5 +243,5 @@ void xe_heci_csc_irq_handler(struct xe_device *xe, u32 iir)
ret = generic_handle_irq_safe(xe->heci_gsc.irq);
if (ret)
- xe_err_ratelimited(xe, "error handling GSC irq: %d\n", ret);
+ xe_err_ratelimited(xe, "failed to handle GSC irq: %d\n", ret);
}
--
2.53.0
next prev parent reply other threads:[~2026-06-05 16:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 16:04 [PATCH 0/5] drm/{i915, xe}: Refactor generic_handle_irq_safe() error messages Jonathan Cavitt
2026-06-05 16:04 ` [PATCH 1/5] drm/xe/printk: Add xe_warn_once() Jonathan Cavitt
2026-06-05 18:16 ` Michal Wajdeczko
2026-06-05 16:04 ` [PATCH 2/5] drm/xe/heci: Use xe print functions in xe_heci_gsc.c Jonathan Cavitt
2026-06-05 18:41 ` Michal Wajdeczko
2026-06-05 19:12 ` Cavitt, Jonathan
2026-06-05 16:04 ` [PATCH 3/5] drm/xe/i2c: Use xe print functions in xe_i2c.c Jonathan Cavitt
2026-06-05 16:04 ` Jonathan Cavitt [this message]
2026-06-05 18:48 ` [PATCH 4/5] drm/{i915, xe}: Refactor generic_handle_irq_safe() error messages Michal Wajdeczko
2026-06-05 16:04 ` [PATCH 5/5] drm/xe/i2c: Report i2c irq handler issue Jonathan Cavitt
2026-06-05 18:42 ` ✓ i915.CI.BAT: success for drm/{i915, xe}: Refactor generic_handle_irq_safe() error messages (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260605160444.3833295-5-jonathan.cavitt@intel.com \
--to=jonathan.cavitt@intel.com \
--cc=alex.zuo@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=raag.jadav@intel.com \
--cc=saurabhg.gupta@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox