From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com, arun.r.murthy@intel.com,
jani.nikula@linux.intel.com,
Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [PATCH v4 02/12] drm/i915/vrr: Use the helper to write EMP_AS_SDP_TL register
Date: Thu, 11 Jun 2026 13:03:04 +0530 [thread overview]
Message-ID: <20260611073316.1439306-3-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20260611073316.1439306-1-ankit.k.nautiyal@intel.com>
Now that intel_dip_write_emp_as_sdp_tl() exists, use it instead of
the open-coded EMP_AS_SDP_TL programming sequence in
intel_vrr_set_transcoder_timings().
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
drivers/gpu/drm/i915/display/intel_vrr.c | 14 ++------------
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
index 6130854a706c..a3dfeaa12e8b 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr.c
+++ b/drivers/gpu/drm/i915/display/intel_vrr.c
@@ -9,7 +9,7 @@
#include "intel_alpm.h"
#include "intel_crtc.h"
#include "intel_de.h"
-#include "intel_dip_regs.h"
+#include "intel_dip.h"
#include "intel_display_regs.h"
#include "intel_display_types.h"
#include "intel_dmc.h"
@@ -658,17 +658,7 @@ void intel_vrr_set_transcoder_timings(const struct intel_crtc_state *crtc_state)
VRR_VSYNC_END(crtc_state->vrr.vsync_end) |
VRR_VSYNC_START(crtc_state->vrr.vsync_start));
- /*
- * For BMG and LNL+ onwards the EMP_AS_SDP_TL is used for programming
- * double buffering point and transmission line for VRR packets for
- * HDMI2.1/DP/eDP/DP->HDMI2.1 PCON.
- * Since currently we support VRR only for DP/eDP, so this is programmed
- * to for Adaptive Sync SDP to Vsync start.
- */
- if (DISPLAY_VERx100(display) == 1401 || DISPLAY_VER(display) >= 20)
- intel_de_write(display,
- EMP_AS_SDP_TL(display, cpu_transcoder),
- EMP_AS_SDP_DB_TL(crtc_state->vrr.vsync_start));
+ intel_dip_write_emp_as_sdp_tl(crtc_state);
}
void
--
2.45.2
next prev parent reply other threads:[~2026-06-11 7:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 7:33 [PATCH v4 00/12] Add support for Common SDP Transmission Line Ankit Nautiyal
2026-06-11 7:33 ` [PATCH v4 01/12] drm/i915/dip: Add new file to handle Data Island Packet hardware Ankit Nautiyal
2026-08-27 6:46 ` Kandpal, Suraj
2026-06-11 7:33 ` Ankit Nautiyal [this message]
2026-08-27 6:49 ` [PATCH v4 02/12] drm/i915/vrr: Use the helper to write EMP_AS_SDP_TL register Kandpal, Suraj
2026-06-11 7:33 ` [PATCH v4 03/12] drm/i915/intel_dip: Add check for DP encoder Ankit Nautiyal
2026-08-27 8:29 ` Kandpal, Suraj
2026-06-11 7:33 ` [PATCH v4 04/12] drm/i915/dp: Add helper to get AS SDP Transmission Line Ankit Nautiyal
2026-09-01 2:55 ` Kandpal, Suraj
2026-06-11 7:33 ` [PATCH v4 05/12] drm/i915/display: Add crtc state for DIP transmission lines Ankit Nautiyal
2026-09-01 2:56 ` Kandpal, Suraj
2026-09-08 15:35 ` Jani Nikula
2026-09-10 2:44 ` Nautiyal, Ankit K
2026-06-11 7:33 ` [PATCH v4 06/12] drm/i915/dip: Store and use AS SDP transmission line from crtc state Ankit Nautiyal
2026-09-01 3:03 ` Kandpal, Suraj
2026-09-08 6:14 ` Nautiyal, Ankit K
2026-06-11 7:33 ` [PATCH v4 07/12] drm/i915/nvl: Add register definitions for common SDP Transmission Line Ankit Nautiyal
2026-06-11 7:33 ` [PATCH v4 08/12] drm/i915/display: Add HAS_COMMON_SDP_TL macro Ankit Nautiyal
2026-09-01 3:26 ` Kandpal, Suraj
2026-06-11 7:33 ` [PATCH v4 09/12] drm/i915/dp: Store SDP transmission lines in crtc_state Ankit Nautiyal
2026-09-01 3:30 ` Kandpal, Suraj
2026-09-08 6:25 ` Nautiyal, Ankit K
2026-06-11 7:33 ` [PATCH v4 10/12] drm/i915/dp: Introduce helpers to enable/disable CMN SDP Transmission line Ankit Nautiyal
2026-06-11 7:33 ` [PATCH v4 11/12] drm/i915/dip: Enable Common " Ankit Nautiyal
2026-06-11 7:33 ` [PATCH v4 12/12] drm/i915/display: Dump DIP Transmission lines Ankit Nautiyal
2026-06-11 9:02 ` ✓ i915.CI.BAT: success for Add support for Common SDP Transmission Line (rev4) Patchwork
2026-06-12 4:59 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260611073316.1439306-3-ankit.k.nautiyal@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=arun.r.murthy@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox