Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <dev@lankhorst.se>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org, Maarten Lankhorst <dev@lankhorst.se>
Subject: [PATCH v9 09/30] drm/i915/display: Make get_vblank_counter use intel_de_read_fw()
Date: Mon, 22 Jun 2026 20:10:22 +0200	[thread overview]
Message-ID: <20260622181044.39335-10-dev@lankhorst.se> (raw)
In-Reply-To: <20260622181044.39335-1-dev@lankhorst.se>

Fixes the following lockdep splat on PREEMPT_RT:
<3> BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48
<3> in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 1373, name: xe_module_load
<3> preempt_count: 1, expected: 0
<3> RCU nest depth: 0, expected: 0
<4> 11 locks held by xe_module_load/1373:
<4>  #0: ffff888107b691a0 (&dev->mutex){....}-{3:3}, at: __driver_attach+0x104/0x220
<4>  #1: ffff88813cd30280 (&dev->clientlist_mutex){+.+.}-{3:3}, at: drm_client_register+0x32/0xe0
<4>  #2: ffffffff837f88f8 (registration_lock){+.+.}-{3:3}, at: register_framebuffer+0x1b/0x50
<4>  #3: ffffffff835985e0 (console_lock){+.+.}-{0:0}, at: fbcon_fb_registered+0x6f/0x90
<4>  #4: ffff88812589e6a0 (&helper->lock){+.+.}-{3:3}, at: __drm_fb_helper_restore_fbdev_mode_unlocked+0x7b/0x110
<4>  #5: ffff88813cd30158 (&dev->master_mutex){+.+.}-{3:3}, at: drm_master_internal_acquire+0x20/0x50
<4>  #6: ffff88812589e488 (&client->modeset_mutex){+.+.}-{3:3}, at: drm_client_modeset_commit_locked+0x2a/0x1b0
<4>  #7: ffffc9000031eef0 (crtc_ww_class_acquire){+.+.}-{0:0}, at: drm_client_modeset_commit_atomic+0x4c/0x2b0
<4>  #8: ffffc9000031ef18 (crtc_ww_class_mutex){+.+.}-{3:3}, at: drm_client_modeset_commit_atomic+0x4c/0x2b0
<4>  #9: ffff888114f7b8b8 (&intel_dp->psr.lock){+.+.}-{3:3}, at: intel_psr_lock+0xc5/0xf0 [xe]
<4>  #10: ffff88812a0cbbc0 (&wl->lock){+.+.}-{2:2}, at: intel_dmc_wl_get+0x3c/0x140 [xe]

This splat will happen otherwise on all tracepoints too, for similar reasons.

Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
---
 drivers/gpu/drm/i915/display/intel_vblank.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_vblank.c b/drivers/gpu/drm/i915/display/intel_vblank.c
index 07dca05332e5b..c0cc0a4c25dbe 100644
--- a/drivers/gpu/drm/i915/display/intel_vblank.c
+++ b/drivers/gpu/drm/i915/display/intel_vblank.c
@@ -132,7 +132,7 @@ u32 g4x_get_vblank_counter(struct drm_crtc *crtc)
 	if (!vblank->max_vblank_count)
 		return 0;
 
-	return intel_de_read(display, PIPE_FRMCOUNT_G4X(display, pipe));
+	return intel_de_read_fw(display, PIPE_FRMCOUNT_G4X(display, pipe));
 }
 
 static u32 intel_crtc_scanlines_since_frame_timestamp(struct intel_crtc *crtc)
-- 
2.53.0


  parent reply	other threads:[~2026-06-22 18:10 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-22 18:10 [PATCH v9 00/30] drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 01/30] drm/vblank_work: Add methods to schedule vblank_work in 2 stages Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 02/30] drm/vblank: Add a 2-stage version of drm_crtc_arm_vblank_event Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 03/30] drm/intel/display: Make intel_crtc_arm_vblank_event static Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 04/30] drm/intel/display: Convert vblank event handling to 2-stage arming Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 05/30] drm/i915/display: Move vblank put until after critical section Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 06/30] drm/i915/display: Remove locking from intel_vblank_evade " Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 07/30] drm/i915/display: Handle vlv dsi workaround in scanline_in_safe_range too Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 08/30] drm/i915: Use preempt_disable/enable_rt() where recommended Maarten Lankhorst
2026-06-22 18:10 ` Maarten Lankhorst [this message]
2026-06-22 18:10 ` [PATCH v9 10/30] drm/i915/display: Do not take uncore lock in i915_get_vblank_counter Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 11/30] drm/i915/display: Make icl_dsi_frame_update use _fw too Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 12/30] drm/i915/display: Use intel_de_read/write_fw in colorops Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 13/30] drm/i915/display: Use intel_de_write_fw in intel_pipe_fastset Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 14/30] drm/i915/display: Make set_pipeconf use the fw variants Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 15/30] drm/i915/gt: Use spin_lock_irq() instead of local_irq_disable() + spin_lock() Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 16/30] drm/i915: Drop the irqs_disabled() check Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 17/30] drm/i915/guc: Consider also RCU depth in busy loop Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 18/30] drm/i915/gt: Fix selftests on PREEMPT_RT Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 19/30] drm/i915/gt: Set stop_timeout() correctly on PREEMPT-RT Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 20/30] drm/i915/display: Remove uncore lock from vlv_atomic_update_fifo Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 21/30] drm/i915: Use sleeping selftests for igt_atomic on PREEMPT_RT Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 22/30] Revert "drm/i915: Depend on !PREEMPT_RT." Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 23/30] PREEMPT_RT injection Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 24/30] FOR-CI: bump MAX_STACK_TRACE_ENTRIES Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 25/30] drm/i915/gt: Add a spinlock to prevent starvation of irq_work Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 26/30] drm/xe: Avoid using stolen memory for DPT Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 27/30] drm/xe/display: Avoid using stolen memory for framebuffer when media gt exists Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 28/30] drm/xe/display: Do not allocate into stolen for new framebuffers Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 29/30] drm/i915/pmu: Convert to raw spinlock Maarten Lankhorst
2026-06-22 18:10 ` [PATCH v9 30/30] drm/i915/guc: Make timestamp.lock a " Maarten Lankhorst
2026-06-23 12:57   ` [PATCH v9.5] drm/i915: Disable "busy" pmu event on CONFIG_PREEMPT_RT Maarten Lankhorst
2026-06-23 13:27   ` [PATCH v9.6] " Maarten Lankhorst
2026-06-22 19:09 ` ✗ i915.CI.BAT: failure for drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe. (rev17) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260622181044.39335-10-dev@lankhorst.se \
    --to=dev@lankhorst.se \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox