Re: [PATCH v8 12/14] drm/xe: Indicate support for luminance on the connector

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The DRIVER_CONNECTOR_LUMINANCE feature flag is placed unconditionally in the general driver features mask instead of inside the display-specific XE_DISPLAY_DRIVER_FEATURES macro.
--

commit 15b98d1b5f359c6f4e02b8f0bf3cb53a02d509bd
Author: Mario Limonciello <mario.limonciello@amd.com>
Subject: drm/xe: Indicate support for luminance on the connector

This commit enables luminance support on connectors for the xe driver, 
allowing eDP panels to report luminance information to userspace.

> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index ee732e5495f7d..b74afe1594842 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -397,6 +397,7 @@ static const struct drm_driver regular_driver = {
>  	    XE_DISPLAY_DRIVER_FEATURES |
>  	    DRIVER_GEM |
>  	    DRIVER_RENDER | DRIVER_SYNCOBJ |
> +	    DRIVER_CONNECTOR_LUMINANCE |

[Severity: Low]
Should DRIVER_CONNECTOR_LUMINANCE be included inside the 
XE_DISPLAY_DRIVER_FEATURES macro rather than added unconditionally here?

When the xe driver is compiled without display support (CONFIG_DRM_XE_DISPLAY
is disabled), XE_DISPLAY_DRIVER_FEATURES correctly evaluates to 0, which omits
DRIVER_MODESET and DRIVER_ATOMIC. 

Because DRIVER_CONNECTOR_LUMINANCE is placed outside of that macro, it appears
the driver will unconditionally advertise this display capability to userspace 
via the DRM_IOCTL_SET_CLIENT_CAP mask, even when the display components are 
compiled out.

>  	    DRIVER_SYNCOBJ_TIMELINE,
>  	.open = xe_file_open,
>  	.postclose = xe_file_close,

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908044035.62093-1-mario.limonciello@amd.com?part=12