From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jani.nikula@intel.com, Imre Deak <imre.deak@intel.com>
Subject: [CI] drm/{i915, xe}: make intel_dmc_suspend() part of display suspend/shutdown calls
Date: Tue, 29 Sep 2026 13:33:58 +0300 [thread overview]
Message-ID: <20260929103358.642813-1-jani.nikula@intel.com> (raw)
Move the intel_dmc_suspend() calls from i915 and xe suspend and shutdown
hooks all the way down to a shared location in
__intel_display_driver_pm_suspend().
This is a change in the suspend/shutdown sequences, but hopefully one
without problems. The main change is moving intel_dmc_suspend() before
irq suspend.
Reviewed-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
Sending [1] one by one for CI to see if it breaks or not.
[1] https://lore.kernel.org/r/cover.1790089118.git.jani.nikula@intel.com
---
drivers/gpu/drm/i915/display/intel_display_driver.c | 2 ++
drivers/gpu/drm/i915/i915_driver.c | 4 ----
drivers/gpu/drm/xe/display/xe_display.c | 4 ----
3 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_driver.c b/drivers/gpu/drm/i915/display/intel_display_driver.c
index 70d112fd4287..77009dca7d0d 100644
--- a/drivers/gpu/drm/i915/display/intel_display_driver.c
+++ b/drivers/gpu/drm/i915/display/intel_display_driver.c
@@ -768,6 +768,8 @@ static int __intel_display_driver_pm_suspend(struct intel_display *display, bool
intel_encoder_suspend_all(display);
+ intel_dmc_suspend(display);
+
return ret;
}
diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
index ce6d20958320..9e047c27a153 100644
--- a/drivers/gpu/drm/i915/i915_driver.c
+++ b/drivers/gpu/drm/i915/i915_driver.c
@@ -1024,8 +1024,6 @@ void i915_driver_shutdown(struct drm_i915_private *i915)
intel_irq_suspend(i915);
- intel_dmc_suspend(display);
-
i915_gem_suspend(i915);
/*
@@ -1096,8 +1094,6 @@ static int i915_drm_suspend(struct drm_device *dev)
dev_priv->suspend_count++;
- intel_dmc_suspend(display);
-
enable_rpm_wakeref_asserts(&dev_priv->runtime_pm);
i915_gem_drain_freed_objects(dev_priv);
diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
index 506f26e9c59a..aab416485e3e 100644
--- a/drivers/gpu/drm/xe/display/xe_display.c
+++ b/drivers/gpu/drm/xe/display/xe_display.c
@@ -170,8 +170,6 @@ void xe_display_shutdown(struct xe_device *xe)
intel_display_driver_shutdown(display);
intel_opregion_suspend(display, PCI_D3cold);
-
- intel_dmc_suspend(display);
}
void xe_display_shutdown_late(struct xe_device *xe)
@@ -248,8 +246,6 @@ void xe_display_pm_suspend(struct xe_device *xe)
intel_display_driver_pm_suspend(display);
intel_opregion_suspend(display, s2idle ? PCI_D1 : PCI_D3cold);
-
- intel_dmc_suspend(display);
}
void xe_display_pm_suspend_late(struct xe_device *xe)
--
2.47.3
next reply other threads:[~2026-09-29 10:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 10:33 Jani Nikula [this message]
2026-09-29 12:04 ` ✗ i915.CI.BAT: failure for drm/{i915, xe}: make intel_dmc_suspend() part of display suspend/shutdown calls Patchwork
2026-09-29 14:09 ` ✓ i915.CI.BAT: success for drm/{i915, xe}: make intel_dmc_suspend() part of display suspend/shutdown calls (rev2) Patchwork
2026-09-29 18:08 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929103358.642813-1-jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox