From: "Christian König" <christian.koenig@amd.com>
To: "André Almeida" <andrealmeid@igalia.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
siqueira@igalia.com, airlied@gmail.com, simona@ffwll.ch,
"Raag Jadav" <raag.jadav@intel.com>,
rodrigo.vivi@intel.com, jani.nikula@linux.intel.com,
"Xaver Hugl" <xaver.hugl@gmail.com>,
"Krzysztof Karas" <krzysztof.karas@intel.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kernel-dev@igalia.com, amd-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v7 1/5] drm: amdgpu: Create amdgpu_vm_print_task_info()
Date: Mon, 16 Jun 2025 09:03:03 +0200 [thread overview]
Message-ID: <22217fcd-f408-49f8-b52e-99196e2872e1@amd.com> (raw)
In-Reply-To: <20250613184348.1761020-2-andrealmeid@igalia.com>
On 6/13/25 20:43, André Almeida wrote:
> To avoid repetitive code in amdgpu, create a function that prints the
> content of struct amdgpu_task_info.
>
> Signed-off-by: André Almeida <andrealmeid@igalia.com>
> ---
> v7: new patch
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 4 +---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 9 +++++++++
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 3 +++
> drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 5 +----
> drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 5 +----
> drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c | 5 +----
> drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 4 +---
> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 5 +----
> 8 files changed, 18 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> index 75262ce8db27..3d887428ca2b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> @@ -124,9 +124,7 @@ static enum drm_gpu_sched_stat amdgpu_job_timedout(struct drm_sched_job *s_job)
>
> ti = amdgpu_vm_get_task_info_pasid(ring->adev, job->pasid);
> if (ti) {
> - dev_err(adev->dev,
> - "Process information: process %s pid %d thread %s pid %d\n",
> - ti->process_name, ti->tgid, ti->task_name, ti->pid);
> + amdgpu_vm_print_task_info(adev, ti);
> amdgpu_vm_put_task_info(ti);
> }
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 3911c78f8282..f2a0132521c2 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -3156,3 +3156,12 @@ bool amdgpu_vm_is_bo_always_valid(struct amdgpu_vm *vm, struct amdgpu_bo *bo)
> {
> return bo && bo->tbo.base.resv == vm->root.bo->tbo.base.resv;
> }
> +
> +inline void amdgpu_vm_print_task_info(struct amdgpu_device *adev,
> + struct amdgpu_task_info *task_info)
Please drop the inline, neither performance critical nor really applicable.
Apart from that looks good to me.
Regards,
Christian.
> +{
> + dev_err(adev->dev,
> + " Process %s pid %d thread %s pid %d\n",
> + task_info->process_name, task_info->tgid,
> + task_info->task_name, task_info->pid);
> +}
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
> index f3ad687125ad..3862a256b9b8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
> @@ -668,4 +668,7 @@ void amdgpu_vm_tlb_fence_create(struct amdgpu_device *adev,
> struct amdgpu_vm *vm,
> struct dma_fence **fence);
>
> +inline void amdgpu_vm_print_task_info(struct amdgpu_device *adev,
> + struct amdgpu_task_info *task_info);
> +
> #endif
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> index a3e2787501f1..7923f491cf73 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> @@ -164,10 +164,7 @@ static int gmc_v10_0_process_interrupt(struct amdgpu_device *adev,
> entry->src_id, entry->ring_id, entry->vmid, entry->pasid);
> task_info = amdgpu_vm_get_task_info_pasid(adev, entry->pasid);
> if (task_info) {
> - dev_err(adev->dev,
> - " in process %s pid %d thread %s pid %d\n",
> - task_info->process_name, task_info->tgid,
> - task_info->task_name, task_info->pid);
> + amdgpu_vm_print_task_info(adev, task_info);
> amdgpu_vm_put_task_info(task_info);
> }
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
> index 72211409227b..f15d691e9a20 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
> @@ -134,10 +134,7 @@ static int gmc_v11_0_process_interrupt(struct amdgpu_device *adev,
> entry->src_id, entry->ring_id, entry->vmid, entry->pasid);
> task_info = amdgpu_vm_get_task_info_pasid(adev, entry->pasid);
> if (task_info) {
> - dev_err(adev->dev,
> - " in process %s pid %d thread %s pid %d)\n",
> - task_info->process_name, task_info->tgid,
> - task_info->task_name, task_info->pid);
> + amdgpu_vm_print_task_info(adev, task_info);
> amdgpu_vm_put_task_info(task_info);
> }
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c
> index b645d3e6a6c8..de763105fdfd 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c
> @@ -127,10 +127,7 @@ static int gmc_v12_0_process_interrupt(struct amdgpu_device *adev,
> entry->src_id, entry->ring_id, entry->vmid, entry->pasid);
> task_info = amdgpu_vm_get_task_info_pasid(adev, entry->pasid);
> if (task_info) {
> - dev_err(adev->dev,
> - " in process %s pid %d thread %s pid %d)\n",
> - task_info->process_name, task_info->tgid,
> - task_info->task_name, task_info->pid);
> + amdgpu_vm_print_task_info(adev, task_info);
> amdgpu_vm_put_task_info(task_info);
> }
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c
> index 99ca08e9bdb5..b45fa0cea9d2 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c
> @@ -1458,9 +1458,7 @@ static int gmc_v8_0_process_interrupt(struct amdgpu_device *adev,
>
> task_info = amdgpu_vm_get_task_info_pasid(adev, entry->pasid);
> if (task_info) {
> - dev_err(adev->dev, " for process %s pid %d thread %s pid %d\n",
> - task_info->process_name, task_info->tgid,
> - task_info->task_name, task_info->pid);
> + amdgpu_vm_print_task_info(adev, task_info);
> amdgpu_vm_put_task_info(task_info);
> }
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> index 282197f4ffb1..78f65aea03f8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> @@ -641,10 +641,7 @@ static int gmc_v9_0_process_interrupt(struct amdgpu_device *adev,
>
> task_info = amdgpu_vm_get_task_info_pasid(adev, entry->pasid);
> if (task_info) {
> - dev_err(adev->dev,
> - " for process %s pid %d thread %s pid %d)\n",
> - task_info->process_name, task_info->tgid,
> - task_info->task_name, task_info->pid);
> + amdgpu_vm_print_task_info(adev, task_info);
> amdgpu_vm_put_task_info(task_info);
> }
>
next prev parent reply other threads:[~2025-06-16 7:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 18:43 [PATCH v7 0/5] drm: Create a task info option for wedge events André Almeida
2025-06-13 18:43 ` [PATCH v7 1/5] drm: amdgpu: Create amdgpu_vm_print_task_info() André Almeida
2025-06-16 7:03 ` Christian König [this message]
2025-06-13 18:43 ` [PATCH v7 2/5] drm: Create a task info option for wedge events André Almeida
2025-06-15 11:01 ` Raag Jadav
2025-06-13 18:43 ` [PATCH v7 3/5] drm/doc: Add a section about "Task information" for the wedge API André Almeida
2025-06-13 18:43 ` [PATCH v7 4/5] drm: amdgpu: Use struct drm_wedge_task_info inside of struct amdgpu_task_info André Almeida
2025-06-16 7:05 ` Christian König
2025-06-13 18:43 ` [PATCH v7 5/5] drm/amdgpu: Make use of drm_wedge_task_info André Almeida
2025-06-13 21:15 ` Alex Deucher
2025-06-16 7:10 ` Christian König
2025-06-13 19:34 ` ✗ i915.CI.BAT: failure for drm: Create a task info option for wedge events (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22217fcd-f408-49f8-b52e-99196e2872e1@amd.com \
--to=christian.koenig@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrealmeid@igalia.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=kernel-dev@igalia.com \
--cc=krzysztof.karas@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=raag.jadav@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=siqueira@igalia.com \
--cc=xaver.hugl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox