From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Matthew Auld <matthew.william.auld@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 3/4] drm/i915: Pass ww ctx to pin_map, v2.
Date: Thu, 29 Apr 2021 16:58:34 +0200 [thread overview]
Message-ID: <254ce000-719f-9e9a-0e4d-dc04db268ff3@linux.intel.com> (raw)
In-Reply-To: <CAM0jSHOkzkt68w60x8WyqHTyU+456eSt=R=6jnM8gDHUk0=MRg@mail.gmail.com>
Op 29-04-2021 om 16:55 schreef Matthew Auld:
> On Thu, 29 Apr 2021 at 11:10, Maarten Lankhorst
> <maarten.lankhorst@linux.intel.com> wrote:
>> This will allow us to explicitly pass the ww to pin_pages,
>> when it starts taking it.
>>
>> This allows us to finally kill off the explicit passing of ww
>> by retrieving it from the obj.
>>
>> Changes since v1:
>> - Rename 'ret' to ptr, fix error handling of return ptr.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> <snip>
>
>> --- a/drivers/gpu/drm/i915/gt/intel_gtt.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_gtt.c
>> @@ -65,7 +65,7 @@ int map_pt_dma_locked(struct i915_address_space *vm, struct drm_i915_gem_object
>> void *vaddr;
>>
>> type = i915_coherent_map_type(vm->i915, obj, true);
>> - vaddr = i915_gem_object_pin_map(obj, type);
>> + vaddr = i915_gem_object_pin_map(obj, NULL, type);
> Don't we need to pass the ww here? For all our page-tables this is
> both our allocate and map for the backing page(lmem or smem), so at
> least for the locked variant here would it not make sense to pass the
> ww from the vma_pin() etc, in case we need to evict stuff?
Actually yeah, seems to be called from i915_vma_pin_ww, so should pass ww along for sure.. I'll respin.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-04-29 14:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 10:10 [Intel-gfx] [PATCH 0/4] drm/i915: Propagate ww parameter to get_pages() Maarten Lankhorst
2021-04-29 10:10 ` [Intel-gfx] [PATCH 1/4] drm/i915: Add ww parameter to get_pages() callback Maarten Lankhorst
2021-04-29 13:21 ` Matthew Auld
2021-04-29 10:10 ` [Intel-gfx] [PATCH 2/4] drm/i915: Add ww context to prepare_(read/write) Maarten Lankhorst
2021-04-29 13:23 ` Matthew Auld
2021-04-29 10:10 ` [Intel-gfx] [PATCH 3/4] drm/i915: Pass ww ctx to pin_map, v2 Maarten Lankhorst
2021-04-29 13:28 ` Matthew Auld
2021-04-29 14:23 ` Maarten Lankhorst
2021-04-29 14:55 ` Matthew Auld
2021-04-29 14:58 ` Maarten Lankhorst [this message]
2021-04-29 10:10 ` [Intel-gfx] [PATCH 4/4] drm/i915: Pass ww ctx to i915_gem_object_pin_pages, v2 Maarten Lankhorst
2021-04-29 13:46 ` Matthew Auld
2021-04-29 15:47 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Propagate ww parameter to get_pages() Patchwork
2021-04-29 16:17 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=254ce000-719f-9e9a-0e4d-dc04db268ff3@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.william.auld@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox