From: "Christian König" <christian.koenig@amd.com>
To: Alex Deucher <alexdeucher@gmail.com>, Kees Cook <keescook@chromium.org>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>,
Karol Herbst <kherbst@redhat.com>, Tom Rix <trix@redhat.com>,
llvm@lists.linux.dev, dri-devel@lists.freedesktop.org,
Chris Wilson <chris@chris-wilson.co.uk>,
Prike Liang <Prike.Liang@amd.com>, Huang Rui <ray.huang@amd.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Evan Quan <evan.quan@amd.com>,
Emma Anholt <emma@anholt.net>,
amd-gfx@lists.freedesktop.org,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
VMware Graphics Reviewers <linux-graphics-maintainer@vmware.com>,
Ben Skeggs <bskeggs@redhat.com>,
nouveau@lists.freedesktop.org, David Airlie <airlied@redhat.com>,
Alex Deucher <alexander.deucher@amd.com>,
Lijo Lazar <lijo.lazar@amd.com>,
Yifan Zhang <yifan1.zhang@amd.com>,
linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
Kevin Wang <kevin1.wang@amd.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Maxime Ripard <mripard@kernel.org>,
Nathan Chancellor <nathan@kernel.org>, Le Ma <le.ma@amd.com>,
Gurchetan Singh <gurchetansingh@chromium.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
virtualization@lists.linux-foundation.org,
Neil Armstrong <neil.armstrong@linaro.org>,
Xiaojian Du <Xiaojian.Du@amd.com>, Lang Yu <Lang.Yu@amd.com>,
Bjorn Andersson <andersson@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org,
Hawking Zhang <Hawking.Zhang@amd.com>,
Melissa Wen <mwen@igalia.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Nirmoy Das <nirmoy.das@intel.com>,
freedreno@lists.freedesktop.org, linux-hardening@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH 1/9] drm/amd/pm: Annotate struct smu10_voltage_dependency_table with __counted_by
Date: Mon, 25 Sep 2023 08:30:30 +0200 [thread overview]
Message-ID: <2635922e-f52a-4e91-40c6-4f1358972786@amd.com> (raw)
In-Reply-To: <CADnq5_P2p3bmczci=pU+pG6f9+hqn=-xp1EynP2345CJZRW08w@mail.gmail.com>
Am 22.09.23 um 19:41 schrieb Alex Deucher:
> On Fri, Sep 22, 2023 at 1:32 PM Kees Cook <keescook@chromium.org> wrote:
>> Prepare for the coming implementation by GCC and Clang of the __counted_by
>> attribute. Flexible array members annotated with __counted_by can have
>> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
>> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
>> functions).
>>
>> As found with Coccinelle[1], add __counted_by for struct smu10_voltage_dependency_table.
>>
>> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
>>
>> Cc: Evan Quan <evan.quan@amd.com>
>> Cc: Alex Deucher <alexander.deucher@amd.com>
>> Cc: "Christian König" <christian.koenig@amd.com>
>> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
>> Cc: David Airlie <airlied@gmail.com>
>> Cc: Daniel Vetter <daniel@ffwll.ch>
>> Cc: Xiaojian Du <Xiaojian.Du@amd.com>
>> Cc: Huang Rui <ray.huang@amd.com>
>> Cc: Kevin Wang <kevin1.wang@amd.com>
>> Cc: amd-gfx@lists.freedesktop.org
>> Cc: dri-devel@lists.freedesktop.org
>> Signed-off-by: Kees Cook <keescook@chromium.org>
> Acked-by: Alex Deucher <alexander.deucher@amd.com>
Mhm, I'm not sure if this is a good idea. That is a structure filled in
by the firmware, isn't it?
That would imply that we might need to byte swap count before it is
checkable.
Regards,
Christian.
>
>> ---
>> drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.h b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.h
>> index 808e0ecbe1f0..42adc2a3dcbc 100644
>> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.h
>> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.h
>> @@ -192,7 +192,7 @@ struct smu10_clock_voltage_dependency_record {
>>
>> struct smu10_voltage_dependency_table {
>> uint32_t count;
>> - struct smu10_clock_voltage_dependency_record entries[];
>> + struct smu10_clock_voltage_dependency_record entries[] __counted_by(count);
>> };
>>
>> struct smu10_clock_voltage_information {
>> --
>> 2.34.1
>>
next prev parent reply other threads:[~2023-09-25 6:30 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 17:32 [Intel-gfx] [PATCH 0/9] drm: Annotate structs with __counted_by Kees Cook
2023-09-22 17:32 ` [Intel-gfx] [PATCH 1/9] drm/amd/pm: Annotate struct smu10_voltage_dependency_table " Kees Cook
2023-09-22 17:41 ` Alex Deucher
2023-09-25 6:30 ` Christian König [this message]
2023-09-25 14:07 ` Alex Deucher
2023-09-25 14:14 ` Alex Deucher
2023-09-25 17:52 ` Kees Cook
2023-09-25 17:56 ` Alex Deucher
2023-09-23 2:13 ` Gustavo A. R. Silva
2023-09-22 17:32 ` [Intel-gfx] [PATCH 2/9] drm/amdgpu/discovery: Annotate struct ip_hw_instance " Kees Cook
2023-09-22 17:42 ` Alex Deucher
2023-09-23 2:14 ` Gustavo A. R. Silva
2023-09-22 17:32 ` [Intel-gfx] [PATCH 3/9] drm/i915/selftests: Annotate struct perf_series " Kees Cook
2023-09-23 2:14 ` Gustavo A. R. Silva
2023-09-25 10:08 ` Andrzej Hajda
2023-09-25 17:50 ` Kees Cook
2023-09-25 12:20 ` Andi Shyti
2023-09-22 17:32 ` [Intel-gfx] [PATCH 4/9] drm/msm/dpu: Annotate struct dpu_hw_intr " Kees Cook
2023-09-23 2:15 ` Gustavo A. R. Silva
2023-09-22 17:32 ` [Intel-gfx] [PATCH 5/9] drm/nouveau/pm: Annotate struct nvkm_perfdom " Kees Cook
2023-09-22 19:00 ` Lyude Paul
2023-09-23 2:15 ` Gustavo A. R. Silva
2023-09-22 17:32 ` [Intel-gfx] [PATCH 6/9] drm/vc4: Annotate struct vc4_perfmon " Kees Cook
2023-09-23 2:16 ` Gustavo A. R. Silva
2023-09-22 17:32 ` [Intel-gfx] [PATCH 7/9] drm/virtio: Annotate struct virtio_gpu_object_array " Kees Cook
2023-09-23 2:36 ` Gustavo A. R. Silva
2023-09-22 17:32 ` [Intel-gfx] [PATCH 8/9] drm/vmwgfx: Annotate struct vmw_surface_dirty " Kees Cook
2023-09-22 21:50 ` Zack Rusin
2023-09-23 2:37 ` Gustavo A. R. Silva
2023-09-22 17:32 ` [Intel-gfx] [PATCH 9/9] drm/v3d: Annotate struct v3d_perfmon " Kees Cook
2023-09-28 15:16 ` Maira Canal
2023-09-23 3:16 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Annotate structs " Patchwork
2023-09-23 3:16 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-09-23 3:34 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-09-29 19:33 ` [Intel-gfx] [PATCH 0/9] " Kees Cook
2023-10-02 9:20 ` Christian König
2023-10-02 15:06 ` Alex Deucher
2023-10-02 16:53 ` Kees Cook
2023-10-02 18:01 ` Christian König
2023-10-02 18:08 ` Kees Cook
2023-10-02 18:11 ` Christian König
2023-10-02 18:22 ` Kees Cook
2023-10-05 9:42 ` Christian König
2023-10-05 16:16 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2635922e-f52a-4e91-40c6-4f1358972786@amd.com \
--to=christian.koenig@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=Lang.Yu@amd.com \
--cc=Prike.Liang@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andersson@kernel.org \
--cc=andrzej.hajda@intel.com \
--cc=bskeggs@redhat.com \
--cc=chris@chris-wilson.co.uk \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=evan.quan@amd.com \
--cc=freedreno@lists.freedesktop.org \
--cc=gurchetansingh@chromium.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keescook@chromium.org \
--cc=kevin1.wang@amd.com \
--cc=kherbst@redhat.com \
--cc=kraxel@redhat.com \
--cc=le.ma@amd.com \
--cc=lijo.lazar@amd.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=mwen@igalia.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=neil.armstrong@linaro.org \
--cc=nirmoy.das@intel.com \
--cc=nouveau@lists.freedesktop.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=ray.huang@amd.com \
--cc=rodrigo.vivi@intel.com \
--cc=trix@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=yifan1.zhang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox