From: "Srivatsa, Anusha" <anusha.srivatsa@intel.com>
To: "Souza, Jose" <jose.souza@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/rps/tgl+: Remove RPS interrupt support
Date: Wed, 23 Feb 2022 17:53:10 +0000 [thread overview]
Message-ID: <270050b550124a1a8fde2aa5cbdec5a5@intel.com> (raw)
In-Reply-To: <20220218210330.48653-1-jose.souza@intel.com>
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of José
> Roberto de Souza
> Sent: Friday, February 18, 2022 1:04 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH] drm/i915/rps/tgl+: Remove RPS interrupt
> support
>
> TGL+ and newer platforms don't support RPS up and low interruption
> limits.
> It is not used for broadwell and newer plaforms that supports execlist but
> here making sure that it is explicit not used even in debug scenarios.
>
> BSpec: 33301
> BSpec: 52069
> BSpec: 9520
> HSD: 1405911647
> Cc: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_rps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c
> b/drivers/gpu/drm/i915/gt/intel_rps.c
> index fd95449ed46da..c8124101aada2 100644
> --- a/drivers/gpu/drm/i915/gt/intel_rps.c
> +++ b/drivers/gpu/drm/i915/gt/intel_rps.c
> @@ -1486,7 +1486,7 @@ void intel_rps_enable(struct intel_rps *rps)
>
> if (has_busy_stats(rps))
> intel_rps_set_timer(rps);
> - else if (GRAPHICS_VER(i915) >= 6)
> + else if (GRAPHICS_VER(i915) >= 6 && GRAPHICS_VER(i915) <= 11)
> intel_rps_set_interrupts(rps);
> else
> /* Ironlake currently uses intel_ips.ko */ {}
> --
> 2.35.1
prev parent reply other threads:[~2022-02-23 17:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 21:03 [Intel-gfx] [PATCH] drm/i915/rps/tgl+: Remove RPS interrupt support José Roberto de Souza
2022-02-19 0:10 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-02-19 17:35 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-02-23 19:03 ` Souza, Jose
2022-02-23 17:53 ` Srivatsa, Anusha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=270050b550124a1a8fde2aa5cbdec5a5@intel.com \
--to=anusha.srivatsa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox