From: Chris Wilson <chris@chris-wilson.co.uk>
To: Dexuan Cui <dexuan.cui@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 1/1] drm/i915: Remove duplicate and unused register #defines in i915_reg.h
Date: Wed, 05 Dec 2012 14:50:04 +0000 [thread overview]
Message-ID: <275ffc$7nc3rr@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1354718237-27348-1-git-send-email-dexuan.cui@intel.com>
On Wed, 5 Dec 2012 22:37:17 +0800, Dexuan Cui <dexuan.cui@intel.com> wrote:
> TRANS_DP_VIDEO_AUDIO is not used at all.
Now you are just opening a can of worms, as none of them are actually
used other than as documentation.
> The other 3 has duplicated #defines.
>
> Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-12-05 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 14:37 [PATCH v2 1/1] drm/i915: Remove duplicate and unused register #defines in i915_reg.h Dexuan Cui
2012-12-05 14:50 ` Chris Wilson [this message]
2012-12-05 15:04 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='275ffc$7nc3rr@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=dexuan.cui@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox