From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/8] drm/i915: Rename execlists->queue_priority to preempt_priority_hint
Date: Tue, 29 Jan 2019 10:41:56 +0000 [thread overview]
Message-ID: <29766985-edb3-036b-5d1b-6ccf926e6831@linux.intel.com> (raw)
In-Reply-To: <154875748964.22998.12622616685399220605@skylake-alporthouse-com>
On 29/01/2019 10:24, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-01-29 10:14:45)
>>
>> On 29/01/2019 08:58, Chris Wilson wrote:
>>> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.h b/drivers/gpu/drm/i915/intel_ringbuffer.h
>>> index 2927b712b973..5e2231d0c2fa 100644
>>> --- a/drivers/gpu/drm/i915/intel_ringbuffer.h
>>> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.h
>>> @@ -293,14 +293,18 @@ struct intel_engine_execlists {
>>> unsigned int port_mask;
>>>
>>> /**
>>> - * @queue_priority: Highest pending priority.
>>> + * @preempt_priority_hint: Highest pending priority.
>>
>> Would queue_priority_hint be better since it is used not just for
>> preemption but to start an idle GPU?
>
> ~o~
>
> It's 2 letters shorter so that's a plus.
>
> And it doesn't always relate to preemption per se. If you are happy with
> adding _hint, then queue_priority_hint it shall be.
Yes I am, I know it is a rebasing hassle, but hint seems a worthy suffix
and preemption would be less accurate.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-01-29 10:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 8:58 [PATCH 1/8] drm/i915: Rename execlists->queue_priority to preempt_priority_hint Chris Wilson
2019-01-29 8:58 ` [PATCH 2/8] drm/i915/execlists: Suppress preempting self Chris Wilson
2019-01-29 10:13 ` Tvrtko Ursulin
2019-01-29 10:22 ` Chris Wilson
2019-01-29 8:58 ` [PATCH 3/8] drm/i915/execlists: Suppress redundant preemption Chris Wilson
2019-01-29 11:15 ` Tvrtko Ursulin
2019-01-29 11:21 ` Chris Wilson
2019-01-29 12:26 ` Tvrtko Ursulin
2019-01-29 12:34 ` Chris Wilson
2019-01-29 15:27 ` [PATCH] " Chris Wilson
2019-01-29 8:58 ` [PATCH 4/8] drm/i915/selftests: Exercise some AB...BA preemption chains Chris Wilson
2019-01-29 8:58 ` [PATCH 5/8] drm/i915: Identify active requests Chris Wilson
2019-01-29 8:58 ` [PATCH 6/8] drm/i915: Remove the intel_engine_notify tracepoint Chris Wilson
2019-01-29 8:58 ` [PATCH 7/8] drm/i915: Replace global breadcrumbs with per-context interrupt tracking Chris Wilson
2019-01-29 8:58 ` [PATCH 8/8] drm/i915: Drop fake breadcrumb irq Chris Wilson
2019-01-29 9:40 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] drm/i915: Rename execlists->queue_priority to preempt_priority_hint Patchwork
2019-01-29 9:44 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-01-29 9:58 ` ✓ Fi.CI.BAT: success " Patchwork
2019-01-29 10:14 ` [PATCH 1/8] " Tvrtko Ursulin
2019-01-29 10:24 ` Chris Wilson
2019-01-29 10:41 ` Tvrtko Ursulin [this message]
2019-01-29 11:33 ` ✓ Fi.CI.IGT: success for series starting with [1/8] " Patchwork
2019-01-29 16:29 ` ✗ Fi.CI.BAT: failure for series starting with [1/8] drm/i915: Rename execlists->queue_priority to preempt_priority_hint (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29766985-edb3-036b-5d1b-6ccf926e6831@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox