From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Intel-gfx@lists.freedesktop.org,
Tvrtko Ursulin <tursulin@ursulin.net>
Subject: Re: [PATCH v5] drm/i915: Engine discovery query
Date: Wed, 3 Oct 2018 13:51:58 +0100 [thread overview]
Message-ID: <2a275ef1-e460-3942-b882-d319b17c781b@linux.intel.com> (raw)
In-Reply-To: <153857054662.28435.11217455138611424140@skylake-alporthouse-com>
On 03/10/2018 13:42, Chris Wilson wrote:
> Quoting Chris Wilson (2018-10-03 13:28:09)
>> Quoting Tvrtko Ursulin (2018-10-03 10:58:55)
>>> +static int
>>> +query_engine_info(struct drm_i915_private *i915,
>>> + struct drm_i915_query_item *query_item)
>>> +{
>>> + for_each_engine(engine, i915, id) {
>>> + struct drm_i915_engine_info info;
>>> +
>>> + if (__copy_from_user(&info, info_ptr, sizeof(info)))
>>> + return -EFAULT;
>>> +
>>> + if (memcmp(&info, &zero_info, sizeof(info)))
>>> + return -EINVAL;
>>
>> You want to have this be an in/out?
I am not sure, perhaps there isn't any benefit in checking that
userspace provided a zeroed block at this level since it is an out only
block. Instead I could just zero the unused fields for them?
> Fwiw, you can use memchr_inv() instead of having a zeroed struct.
Ah cool, thanks, saw that one before but forgot about it.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-10-03 12:52 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 16:15 [PATCH] drm/i915: Engine discovery query Tvrtko Ursulin
2018-10-01 16:21 ` Tvrtko Ursulin
2018-10-01 16:23 ` Tvrtko Ursulin
2018-10-01 16:24 ` Chris Wilson
2018-10-01 16:41 ` Tvrtko Ursulin
2018-10-01 19:39 ` Chris Wilson
2018-10-02 9:05 ` Tvrtko Ursulin
2018-10-02 9:49 ` Chris Wilson
2018-10-01 16:40 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Engine discovery query (rev3) Patchwork
2018-10-01 17:02 ` ✓ Fi.CI.BAT: success " Patchwork
2018-10-01 18:59 ` ✓ Fi.CI.IGT: " Patchwork
2018-10-03 9:58 ` [PATCH v5] drm/i915: Engine discovery query Tvrtko Ursulin
2018-10-03 12:28 ` Chris Wilson
2018-10-03 12:42 ` Chris Wilson
2018-10-03 12:51 ` Tvrtko Ursulin [this message]
2018-10-03 12:56 ` Chris Wilson
2018-10-04 10:51 ` [PATCH v6] " Tvrtko Ursulin
2018-10-04 11:03 ` Lionel Landwerlin
2018-10-04 11:10 ` Lionel Landwerlin
2018-10-04 11:14 ` Tvrtko Ursulin
2018-10-04 11:32 ` [PATCH v7] " Tvrtko Ursulin
2018-10-04 11:38 ` Lionel Landwerlin
2018-10-04 14:32 ` Joonas Lahtinen
2018-10-05 8:34 ` Tvrtko Ursulin
2018-10-05 9:21 ` Chris Wilson
2018-10-05 11:09 ` Joonas Lahtinen
2018-10-04 16:33 ` [PATCH v6] " Chris Wilson
2018-10-05 8:26 ` Tvrtko Ursulin
2018-10-05 10:35 ` Chris Wilson
2018-10-03 10:09 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Engine discovery query (rev4) Patchwork
2018-10-03 10:30 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-10-04 11:53 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Engine discovery query (rev6) Patchwork
2018-10-04 12:14 ` ✓ Fi.CI.BAT: success " Patchwork
2018-10-04 19:05 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a275ef1-e460-3942-b882-d319b17c781b@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox