From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Matt Roper <matthew.d.roper@intel.com>,
Matt Atwood <matthew.s.atwood@intel.com>
Cc: intel-gfx@lists.freedesktop.org, lucas.demarchi@intel.com
Subject: Re: [Intel-gfx] [PATCH v4] drm/i915/mtl: Initial display workarounds
Date: Tue, 13 Dec 2022 11:45:37 +0000 [thread overview]
Message-ID: <2a8527c8-95ba-4a06-550b-df991eaa3cb7@linux.intel.com> (raw)
In-Reply-To: <Y5O7fni8yzeV+cqR@mdroper-desk1.amr.corp.intel.com>
On 09/12/2022 22:49, Matt Roper wrote:
> On Fri, Dec 09, 2022 at 02:05:43PM -0800, Matt Atwood wrote:
>> From: Jouni Högander <jouni.hogander@intel.com>
>>
>> This patch introduces initial workarounds for mtl platform
>>
>> v2: switch IS_MTL_DISPLAY_STEP to use IS_METEORLAKE from testing display
>> ver. (Tvrtko)
>>
>> v3: clerical issues, extend 16015201720 to mtl. (MattR)
>>
>> v4: make sure 16015201720 includes display 13. (MattR)
>>
>> Bspec: 66624
>>
>> Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
>> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
>
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>
>> ---
>> drivers/gpu/drm/i915/display/intel_dmc.c | 4 ++--
>> drivers/gpu/drm/i915/display/intel_fbc.c | 6 +++--
>> drivers/gpu/drm/i915/display/intel_hdmi.c | 3 ++-
>> drivers/gpu/drm/i915/display/intel_psr.c | 27 ++++++++++++++++-------
>> drivers/gpu/drm/i915/i915_drv.h | 4 ++++
>> 5 files changed, 31 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
>> index eff3add70611..8f4880a17ae0 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dmc.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
>> @@ -387,11 +387,11 @@ static void pipedmc_clock_gating_wa(struct drm_i915_private *i915, bool enable)
>> {
>> enum pipe pipe;
>>
>> - if (DISPLAY_VER(i915) != 13)
>> + if (DISPLAY_VER(i915) < 13)
>> return;
>>
>> /*
>> - * Wa_16015201720:adl-p,dg2
>> + * Wa_16015201720:adl-p,dg2, mtl
[stray space but nvm]
Recently we started a little bit of discussion on whether these comments
will be getting updated or completely removed which was left hanging in
the air. Are we trending towards a mess of them being completely
unreliable becuase different people are following different direction here?
Regards,
Tvrtko
>> * The WA requires clock gating to be disabled all the time
>> * for pipe A and B.
>> * For pipe C and D clock gating needs to be disabled only
>> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
>> index deba0c49c827..5e69d3c11d21 100644
>> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
>> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
>> @@ -811,7 +811,7 @@ static void intel_fbc_program_cfb(struct intel_fbc *fbc)
>>
>> static void intel_fbc_program_workarounds(struct intel_fbc *fbc)
>> {
>> - /* Wa_22014263786:icl,jsl,tgl,dg1,rkl,adls,adlp */
>> + /* Wa_22014263786:icl,jsl,tgl,dg1,rkl,adls,adlp,mtl */
>> if (DISPLAY_VER(fbc->i915) >= 11 && !IS_DG2(fbc->i915))
>> intel_de_rmw(fbc->i915, ILK_DPFC_CHICKEN(fbc->id), 0,
>> DPFC_CHICKEN_FORCE_SLB_INVALIDATION);
>> @@ -1091,7 +1091,9 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state,
>> }
>>
>> /* Wa_14016291713 */
>> - if (IS_DISPLAY_VER(i915, 12, 13) && crtc_state->has_psr) {
>> + if ((IS_DISPLAY_VER(i915, 12, 13) ||
>> + IS_MTL_DISPLAY_STEP(i915, STEP_A0, STEP_C0)) &&
>> + crtc_state->has_psr) {
>> plane_state->no_fbc_reason = "PSR1 enabled (Wa_14016291713)";
>> return 0;
>> }
>> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
>> index e82f8a07e2b0..efa2da080f62 100644
>> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
>> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
>> @@ -537,7 +537,8 @@ void hsw_write_infoframe(struct intel_encoder *encoder,
>> 0);
>>
>> /* Wa_14013475917 */
>> - if (DISPLAY_VER(dev_priv) == 13 && crtc_state->has_psr &&
>> + if ((DISPLAY_VER(dev_priv) == 13 ||
>> + IS_MTL_DISPLAY_STEP(dev_priv, STEP_A0, STEP_B0)) && crtc_state->has_psr &&
>> type == DP_SDP_VSC)
>> return;
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
>> index 5b678916e6db..9820e5fdd087 100644
>> --- a/drivers/gpu/drm/i915/display/intel_psr.c
>> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
>> @@ -797,7 +797,7 @@ static bool psr2_granularity_check(struct intel_dp *intel_dp,
>> return intel_dp->psr.su_y_granularity == 4;
>>
>> /*
>> - * adl_p and display 14+ platforms has 1 line granularity.
>> + * adl_p and mtl platforms have 1 line granularity.
>> * For other platforms with SW tracking we can adjust the y coordinates
>> * to match sink requirement if multiple of 4.
>> */
>> @@ -1170,11 +1170,14 @@ static void intel_psr_enable_source(struct intel_dp *intel_dp,
>> PSR2_ADD_VERTICAL_LINE_COUNT);
>>
>> /*
>> - * Wa_16014451276:adlp
>> + * Wa_16014451276:adlp,mtl[a0,b0]
>> * All supported adlp panels have 1-based X granularity, this may
>> * cause issues if non-supported panels are used.
>> */
>> - if (IS_ALDERLAKE_P(dev_priv))
>> + if (IS_MTL_DISPLAY_STEP(dev_priv, STEP_A0, STEP_B0))
>> + intel_de_rmw(dev_priv, MTL_CHICKEN_TRANS(cpu_transcoder), 0,
>> + ADLP_1_BASED_X_GRANULARITY);
>> + else if (IS_ALDERLAKE_P(dev_priv))
>> intel_de_rmw(dev_priv, CHICKEN_TRANS(cpu_transcoder), 0,
>> ADLP_1_BASED_X_GRANULARITY);
>>
>> @@ -1185,8 +1188,12 @@ static void intel_psr_enable_source(struct intel_dp *intel_dp,
>> TRANS_SET_CONTEXT_LATENCY_MASK,
>> TRANS_SET_CONTEXT_LATENCY_VALUE(1));
>>
>> - /* Wa_16012604467:adlp */
>> - if (IS_ALDERLAKE_P(dev_priv))
>> + /* Wa_16012604467:adlp,mtl[a0,b0] */
>> + if (IS_MTL_DISPLAY_STEP(dev_priv, STEP_A0, STEP_B0))
>> + intel_de_rmw(dev_priv,
>> + MTL_CLKGATE_DIS_TRANS(cpu_transcoder), 0,
>> + MTL_CLKGATE_DIS_TRANS_DMASC_GATING_DIS);
>> + else if (IS_ALDERLAKE_P(dev_priv))
>> intel_de_rmw(dev_priv, CLKGATE_DIS_MISC, 0,
>> CLKGATE_DIS_MISC_DMASC_GATING_DIS);
>>
>> @@ -1362,8 +1369,12 @@ static void intel_psr_disable_locked(struct intel_dp *intel_dp)
>> TRANS_SET_CONTEXT_LATENCY(intel_dp->psr.transcoder),
>> TRANS_SET_CONTEXT_LATENCY_MASK, 0);
>>
>> - /* Wa_16012604467:adlp */
>> - if (IS_ALDERLAKE_P(dev_priv))
>> + /* Wa_16012604467:adlp,mtl[a0,b0] */
>> + if (IS_MTL_DISPLAY_STEP(dev_priv, STEP_A0, STEP_B0))
>> + intel_de_rmw(dev_priv,
>> + MTL_CLKGATE_DIS_TRANS(intel_dp->psr.transcoder),
>> + MTL_CLKGATE_DIS_TRANS_DMASC_GATING_DIS, 0);
>> + else if (IS_ALDERLAKE_P(dev_priv))
>> intel_de_rmw(dev_priv, CLKGATE_DIS_MISC,
>> CLKGATE_DIS_MISC_DMASC_GATING_DIS, 0);
>>
>> @@ -1625,7 +1636,7 @@ static void psr2_man_trk_ctl_calc(struct intel_crtc_state *crtc_state,
>>
>> if (full_update) {
>> /*
>> - * Not applying Wa_14014971508:adlp as we do not support the
>> + * Not applying Wa_14014971508:adlp,mtl as we do not support the
>> * feature that requires this workaround.
>> */
>> val |= man_trk_ctl_single_full_frame_bit_get(dev_priv);
>> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>> index a8a5bd426e78..0ad206f76b7b 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.h
>> +++ b/drivers/gpu/drm/i915/i915_drv.h
>> @@ -727,6 +727,10 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
>> (IS_SUBPLATFORM(__i915, INTEL_METEORLAKE, INTEL_SUBPLATFORM_##variant) && \
>> IS_GRAPHICS_STEP(__i915, since, until))
>>
>> +#define IS_MTL_DISPLAY_STEP(__i915, since, until) \
>> + (IS_METEORLAKE(__i915) && \
>> + IS_DISPLAY_STEP(__i915, since, until))
>> +
>> /*
>> * DG2 hardware steppings are a bit unusual. The hardware design was forked to
>> * create three variants (G10, G11, and G12) which each have distinct
>> --
>> 2.38.1
>>
>
next prev parent reply other threads:[~2022-12-13 11:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 22:05 [Intel-gfx] [PATCH v4] drm/i915/mtl: Initial display workarounds Matt Atwood
2022-12-09 22:24 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/mtl: Initial display workarounds (rev3) Patchwork
2022-12-09 22:49 ` [Intel-gfx] [PATCH v4] drm/i915/mtl: Initial display workarounds Matt Roper
2022-12-13 11:45 ` Tvrtko Ursulin [this message]
2022-12-13 21:53 ` Matt Roper
2022-12-16 9:01 ` Tvrtko Ursulin
2022-12-09 22:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Initial display workarounds (rev3) Patchwork
2022-12-10 15:06 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-12-12 18:31 ` Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a8527c8-95ba-4a06-550b-df991eaa3cb7@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=matthew.s.atwood@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox