From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/i915/selftests: Skip live timeline/suspend tests if wedged
Date: Mon, 15 Apr 2019 11:44:06 +0100 [thread overview]
Message-ID: <2c7cedc8-ba7e-1cd7-6a55-7b76c38bac8a@linux.intel.com> (raw)
In-Reply-To: <20190413125820.14112-4-chris@chris-wilson.co.uk>
On 13/04/2019 13:58, Chris Wilson wrote:
> If the driver is wedged, we can not issue the requests to exercise the
> timelines or the system across suspend, so skip the tests. live_hangcheck
> is there to fail if we cannot recover.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/selftests/i915_gem.c | 3 +++
> drivers/gpu/drm/i915/selftests/i915_timeline.c | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem.c b/drivers/gpu/drm/i915/selftests/i915_gem.c
> index 50bb7bbd26d3..6fd70d326468 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_gem.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_gem.c
> @@ -215,5 +215,8 @@ int i915_gem_live_selftests(struct drm_i915_private *i915)
> SUBTEST(igt_gem_hibernate),
> };
>
> + if (i915_terminally_wedged(i915))
> + return 0;
> +
> return i915_subtests(tests, i915);
> }
> diff --git a/drivers/gpu/drm/i915/selftests/i915_timeline.c b/drivers/gpu/drm/i915/selftests/i915_timeline.c
> index 8e7bcaa1eb66..bd96afcadfe7 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_timeline.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_timeline.c
> @@ -838,5 +838,8 @@ int i915_timeline_live_selftests(struct drm_i915_private *i915)
> SUBTEST(live_hwsp_wrap),
> };
>
> + if (i915_terminally_wedged(i915))
> + return 0;
> +
> return i915_subtests(tests, i915);
> }
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-04-15 10:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-13 12:58 [PATCH 1/4] drm/i915: Verify workarounds immediately after application Chris Wilson
2019-04-13 12:58 ` [PATCH 2/4] drm/i915: Verify the engine workarounds stick on application Chris Wilson
2019-04-15 10:41 ` Tvrtko Ursulin
2019-04-15 10:45 ` Chris Wilson
2019-04-15 10:55 ` Chris Wilson
2019-04-13 12:58 ` [PATCH 3/4] drm/i915: Make workaround verification *optional* Chris Wilson
2019-04-13 12:58 ` [PATCH 4/4] drm/i915/selftests: Skip live timeline/suspend tests if wedged Chris Wilson
2019-04-15 10:44 ` Tvrtko Ursulin [this message]
2019-04-13 13:45 ` ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Verify workarounds immediately after application Patchwork
2019-04-13 14:48 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c7cedc8-ba7e-1cd7-6a55-7b76c38bac8a@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox