Re: [Intel-gfx] [PATCH] drm/i915: Don't show client busyness in fdinfo with GuC submission

["Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>]

On 4/13/2022 3:57 PM, Ashutosh Dixit wrote:
> Client busyness is not available when GuC submission is used. Don't show it
> in fdinfo till this is supported by GuC.

GuC does support this, but we don't yet have code in place in i915 to 
fetch the data, so this commit message needs a slightly rewording to 
make that clear.

>
> Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/5564
> Fixes: 055634e4b62f ("drm/i915: Expose client engine utilisation via fdinfo")
> Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> Cc: John Harrison <john.c.harrison@intel.com>
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
>   drivers/gpu/drm/i915/i915_drm_client.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drm_client.c b/drivers/gpu/drm/i915/i915_drm_client.c
> index e539f6b23060..e7fae4a326ab 100644
> --- a/drivers/gpu/drm/i915/i915_drm_client.c
> +++ b/drivers/gpu/drm/i915/i915_drm_client.c
> @@ -145,7 +145,7 @@ void i915_drm_client_fdinfo(struct seq_file *m, struct file *f)
>   		   PCI_SLOT(pdev->devfn), PCI_FUNC(pdev->devfn));
>   	seq_printf(m, "drm-client-id:\t%u\n", client->id);
>   
> -	if (GRAPHICS_VER(i915) < 8)
> +	if (GRAPHICS_VER(i915) < 8 || intel_guc_submission_is_used(&i915->gt0.uc.guc))

 From outside the GuC code we usually call intel_uc_uses_guc_submission().
Also, this needs a comment to explain that this is temporary and will be 
removed once we implement the feature in the GuC submission back-end.

Daniele

>   		return;
>   
>   	for (i = 0; i < ARRAY_SIZE(uabi_class_names); i++)