Re: [Intel-gfx] [PATCH] drm/i915/uc: remove accidental static from a local variable

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 11/05/2022 10:46, Jani Nikula wrote:
> The arrays are static const, but the pointer shouldn't be static.
> 
> Fixes: 3d832f370d16 ("drm/i915/uc: Allow platforms to have GuC but not HuC")
> Cc: John Harrison <John.C.Harrison@Intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>   drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
> index 9361532726d6..d2c5c9367cc4 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
> @@ -156,7 +156,7 @@ __uc_fw_auto_select(struct drm_i915_private *i915, struct intel_uc_fw *uc_fw)
>   		[INTEL_UC_FW_TYPE_GUC] = { blobs_guc, ARRAY_SIZE(blobs_guc) },
>   		[INTEL_UC_FW_TYPE_HUC] = { blobs_huc, ARRAY_SIZE(blobs_huc) },
>   	};
> -	static const struct uc_fw_platform_requirement *fw_blobs;
> +	const struct uc_fw_platform_requirement *fw_blobs;
>   	enum intel_platform p = INTEL_INFO(i915)->platform;
>   	u32 fw_count;
>   	u8 rev = INTEL_REVID(i915);

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Domain owners were copied in this case (mailman just dropped it from the 
mailing list copy?) on this one, but maybe needed extra prodding.

Regards,

Tvrtko