From: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>
To: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>
Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v1 1/1] drm/i915/pxp: Add drm_dbgs for critical PXP events.
Date: Wed, 13 Sep 2023 22:21:40 +0000 [thread overview]
Message-ID: <2d862e6d59a9c549fd31269b8b776d1a6fcd24a8.camel@intel.com> (raw)
In-Reply-To: <87o7i9f4c5.fsf@intel.com>
On Mon, 2023-09-11 at 12:26 +0300, Jani Nikula wrote:
> On Wed, 06 Sep 2023, Alan Previn <alan.previn.teres.alexis@intel.com> wrote:
> > Debugging PXP issues can't even begin without understanding precedding
> > sequence of events. Add drm_dbg into the most important PXP events.
> >
> > Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
alan:snip
>
> > +
> > + drm_dbg(&pxp->ctrl_gt->i915->drm, "PXP: %s invoked", __func__);
>
> drm_dbg already covers __func__ (via __builtin_return_address(0) in
> __drm_dev_dbg), it's redundant.
>
> Ditto for all added debugs below.
My bad - yup - will fix them.
Thanks for taking time to review this patch.
...alan
>
prev parent reply other threads:[~2023-09-13 22:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 0:20 [Intel-gfx] [PATCH v1 1/1] drm/i915/pxp: Add drm_dbgs for critical PXP events Alan Previn
2023-09-07 3:06 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v1,1/1] " Patchwork
2023-09-07 3:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-09-07 5:00 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-09-11 9:26 ` [Intel-gfx] [PATCH v1 1/1] " Jani Nikula
2023-09-13 22:21 ` Teres Alexis, Alan Previn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d862e6d59a9c549fd31269b8b776d1a6fcd24a8.camel@intel.com \
--to=alan.previn.teres.alexis@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox