Re: [Intel-gfx] [PATCH] drm/print: Add drm_dbg_ratelimited

[John Harrison <john.c.harrison@intel.com>]

On 10/9/2023 09:52, Andi Shyti wrote:
> Hi,
>
>> From: Nirmoy Das <nirmoy.das@intel.com>
>>
>> Add a function for ratelimitted debug print.
>>
>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Cc: Maxime Ripard <mripard@kernel.org>
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: David Airlie <airlied@gmail.com>
>> Cc: Daniel Vetter <daniel@ffwll.ch>
>> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
>> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
>> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> Just a kind reminder!
>
> This is the second time this patch has been sent and we have seen
> some potential use of the drm_dbg_ratelimited().
But this patch does not actually add a user. So it is dead code at this 
point, which is not allowed.

If you have code that wants to use such a helper then the helper should 
be part of the patch that adds that code.

John.

>
> Any feedback?
>
> Thanks,
> Andi