From: Matthew Auld <matthew.auld@intel.com>
To: Jani Nikula <jani.nikula@intel.com>,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
Anshuman Gupta <anshuman.gupta@intel.com>,
Andi Shyti <andi.shyti@linux.intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/5] drm/i915/gem: fix bitwise and logical AND mixup
Date: Wed, 18 Sep 2024 12:31:06 +0100 [thread overview]
Message-ID: <30f6a93c-eb20-4f48-b006-e8e4fa2315f9@intel.com> (raw)
In-Reply-To: <dec5992d78db5bc556600c64ce72aa9b19c96c77.1726658138.git.jani.nikula@intel.com>
On 18/09/2024 12:17, Jani Nikula wrote:
> CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND is an int, defaulting to 250. When
> the wakeref is non-zero, it's either -1 or a dynamically allocated
> pointer, depending on CONFIG_DRM_I915_DEBUG_RUNTIME_PM. It's likely that
> the code works by coincidence with the bitwise AND, but with
> CONFIG_DRM_I915_DEBUG_RUNTIME_PM=y, there's the off chance that the
> condition evaluates to false, and intel_wakeref_auto() doesn't get
> called. Switch to the intended logical AND.
>
> Fixes: ad74457a6b5a ("drm/i915/dgfx: Release mmap on rpm suspend")
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Anshuman Gupta <anshuman.gupta@intel.com>
> Cc: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: <stable@vger.kernel.org> # v6.1+
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
next prev parent reply other threads:[~2024-09-18 11:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 11:17 [PATCH 0/5] drm/i915: wakeref fixes and improvements Jani Nikula
2024-09-18 11:17 ` [PATCH 1/5] drm/i915/gem: fix bitwise and logical AND mixup Jani Nikula
2024-09-18 11:31 ` Matthew Auld [this message]
2024-09-18 13:24 ` Andi Shyti
2024-09-18 15:05 ` Nathan Chancellor
2024-09-18 17:26 ` Jani Nikula
2024-09-18 11:17 ` [PATCH 2/5] drm/i915: use INTEL_WAKEREF_DEF instead of magic -1 for intel_wakeref_t Jani Nikula
2024-09-18 11:17 ` [PATCH 3/5] drm/i915/gt: add a macro for mock gt wakeref special value and use it Jani Nikula
2024-09-18 11:17 ` [PATCH 4/5] drm/i915/audio: be explicit about intel_wakeref_t conversions Jani Nikula
2024-09-18 11:17 ` [PATCH 5/5] drm/i915: switch intel_wakeref_t underlying type to struct ref_tracker * Jani Nikula
2024-09-18 16:23 ` kernel test robot
2024-09-18 14:19 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: wakeref fixes and improvements Patchwork
2024-09-18 14:19 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-09-18 14:28 ` ✓ Fi.CI.BAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30f6a93c-eb20-4f48-b006-e8e4fa2315f9@intel.com \
--to=matthew.auld@intel.com \
--cc=andi.shyti@linux.intel.com \
--cc=anshuman.gupta@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox