From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, Intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 2/5] drm/i915: Expose list of clients in sysfs
Date: Mon, 16 Dec 2019 18:34:26 +0000 [thread overview]
Message-ID: <31f99b94-ac03-741b-1ffe-7bac39320341@linux.intel.com> (raw)
In-Reply-To: <157650071542.2428.8379097773696203670@skylake-alporthouse-com>
On 16/12/2019 12:51, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-12-16 12:07:01)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Expose a list of clients with open file handles in sysfs.
>>
>> This will be a basis for a top-like utility showing per-client and per-
>> engine GPU load.
>>
>> Currently we only expose each client's pid and name under opaque numbered
>> directories in /sys/class/drm/card0/clients/.
>>
>> For instance:
>>
>> /sys/class/drm/card0/clients/3/name: Xorg
>> /sys/class/drm/card0/clients/3/pid: 5664
>>
>> v2:
>> Chris Wilson:
>> * Enclose new members into dedicated structs.
>> * Protect against failed sysfs registration.
>>
>> v3:
>> * sysfs_attr_init.
>>
>> v4:
>> * Fix for internal clients.
>>
>> v5:
>> * Use cyclic ida for client id. (Chris)
>
> I think we are now in the age of xa_alloc_cyclic(). At least the
> immediate benefit is that we don't have to worry about the ida locking.
Also spin locks and GFP_KERNEL in the current patch do not mix well. Use
with caution until I send the updated version out.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-16 18:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 12:06 [Intel-gfx] [PATCH 0/5] Per client engine busyness Tvrtko Ursulin
2019-12-16 12:07 ` [Intel-gfx] [PATCH 1/5] drm/i915: Track per-context " Tvrtko Ursulin
2019-12-16 12:40 ` Chris Wilson
2019-12-16 13:09 ` Tvrtko Ursulin
2020-01-30 18:05 ` Tvrtko Ursulin
2020-01-30 21:42 ` Chris Wilson
2019-12-16 12:07 ` [Intel-gfx] [PATCH 2/5] drm/i915: Expose list of clients in sysfs Tvrtko Ursulin
2019-12-16 12:51 ` Chris Wilson
2019-12-16 18:34 ` Tvrtko Ursulin [this message]
2019-12-16 12:53 ` Chris Wilson
2019-12-16 13:13 ` Tvrtko Ursulin
2019-12-17 17:21 ` Tvrtko Ursulin
2019-12-17 17:26 ` Chris Wilson
2019-12-16 12:55 ` Chris Wilson
2019-12-16 13:16 ` Tvrtko Ursulin
2019-12-16 13:17 ` Chris Wilson
2019-12-16 13:28 ` Tvrtko Ursulin
2019-12-16 13:41 ` Chris Wilson
2019-12-16 12:07 ` [Intel-gfx] [PATCH 3/5] drm/i915: Update client name on context create Tvrtko Ursulin
2019-12-16 12:57 ` Chris Wilson
2019-12-16 12:07 ` [Intel-gfx] [PATCH 4/5] drm/i915: Expose per-engine client busyness Tvrtko Ursulin
2019-12-16 12:07 ` [Intel-gfx] [PATCH 5/5] drm/i915: Add sysfs toggle to enable per-client engine stats Tvrtko Ursulin
2019-12-16 13:09 ` [Intel-gfx] [PATCH 0/5] Per client engine busyness Chris Wilson
2019-12-16 13:20 ` Tvrtko Ursulin
2019-12-16 17:45 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-12-16 17:58 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31f99b94-ac03-741b-1ffe-7bac39320341@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox