Re: [RFC PATCH 0/4] New Helper to Initialise writeback connector

[Harry Wentland <harry.wentland@amd.com>]

On 2025-06-13 02:15, Suraj Kandpal wrote:
> This series is for review comments only and is not tested.
> This series added a helper to be able to initialise writeback connector
> in a way where drivers can send their own connector and encoder.
> 

I've only skimmed it but this looks nice. If I understand this
right it should solve the problem where drivers need to check
whether they're dealing with a drm_writeback_connector or a
my_driver_connector.

Harry

> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> 
> Suraj Kandpal (4):
>   drm/writeback: Add function that takes preallocated connector
>   drm/i915/writeback: Add writeback registers
>   drm/i915/writeback: Add some preliminary writeback definitions
>   drm/i915/writeback: Init writeback connector
> 
>  drivers/gpu/drm/drm_writeback.c               |  83 +++++++++++
>  drivers/gpu/drm/i915/Makefile                 |   1 +
>  drivers/gpu/drm/i915/display/intel_display.h  |   4 +
>  .../drm/i915/display/intel_display_device.c   |  26 +++-
>  .../drm/i915/display/intel_display_device.h   |   2 +-
>  .../drm/i915/display/intel_display_limits.h   |   2 +
>  .../drm/i915/display/intel_display_types.h    |   1 +
>  .../gpu/drm/i915/display/intel_writeback.c    | 131 +++++++++++++++++
>  .../gpu/drm/i915/display/intel_writeback.h    |  17 +++
>  .../drm/i915/display/intel_writeback_reg.h    | 134 ++++++++++++++++++
>  include/drm/drm_writeback.h                   |   7 +
>  11 files changed, 405 insertions(+), 3 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/display/intel_writeback.c
>  create mode 100644 drivers/gpu/drm/i915/display/intel_writeback.h
>  create mode 100644 drivers/gpu/drm/i915/display/intel_writeback_reg.h
>