Re: [PATCH v2 1/2] drm/print: describe 6th & 9th bit of drm.debug

["Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>]

On 5/23/2026 1:25 AM, Michał Grzelak wrote:
> On Fri, 22 May 2026, Michał Grzelak wrote:
>> Setting 6th or 9th bit of drm.debug change debug logging. Meanwhile
>> `modinfo drm` does not inform about it at all.
>>
>> Add info to MODULE_PARAM_DESC(debug, ...) about setting 6th and 9th bit
>> basing on DECLARE_DYNDBG_CLASSMAP(drm_debug_classes, ...). Match
>> description of corresponding bits with enum drm_debug_category. Include
>> 9th bit in the example with enabling all possible logging provided at
>> comment at include/drm/drm_print.h.
>>
>> Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
> 
> What should have been added here is R-B: tag provided by Chaitanya,
> which currently is very much absent. The omission was not intentional.
> 

No worries :) still LGTM

Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>


> BR,
> Michał
> 
>> ---
>> drivers/gpu/drm/drm_print.c | 4 +++-
>> include/drm/drm_print.h     | 2 +-
>> 2 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c
>> index ded9461df5f2..86cef1a37678 100644
>> --- a/drivers/gpu/drm/drm_print.c
>> +++ b/drivers/gpu/drm/drm_print.c
>> @@ -50,8 +50,10 @@ MODULE_PARM_DESC(debug, "Enable debug output, where 
>> each bit enables a debug cat
>> "\t\tBit 3 (0x08)  will enable PRIME messages (prime code)\n"
>> "\t\tBit 4 (0x10)  will enable ATOMIC messages (atomic code)\n"
>> "\t\tBit 5 (0x20)  will enable VBL messages (vblank code)\n"
>> +"\t\tBit 6 (0x40)  will enable STATE messages (atomic state code)\n"
>> "\t\tBit 7 (0x80)  will enable LEASE messages (leasing code)\n"
>> -"\t\tBit 8 (0x100) will enable DP messages (displayport code)");
>> +"\t\tBit 8 (0x100) will enable DP messages (displayport code)\n"
>> +"\t\tBit 9 (0x200) will enable DRMRES messages (managed resources 
>> code)");
>>
>> #if !defined(CONFIG_DRM_USE_DYNAMIC_DEBUG)
>> module_param_named(debug, __drm_debug, ulong, 0600);
>> diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
>> index ab017b05e175..2adc5ac688e1 100644
>> --- a/include/drm/drm_print.h
>> +++ b/include/drm/drm_print.h
>> @@ -87,7 +87,7 @@ extern unsigned long __drm_debug;
>>  *  - drm.debug=0x2 will enable DRIVER messages
>>  *  - drm.debug=0x3 will enable CORE and DRIVER messages
>>  *  - ...
>> - *  - drm.debug=0x1ff will enable all messages
>> + *  - drm.debug=0x3ff will enable all messages
>>  *
>>  * An interesting feature is that it's possible to enable verbose 
>> logging at
>>  * run-time by echoing the debug value in its sysfs node::
>> -- 
>> 2.45.2
>>
>>