From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Remove stolen object spam
Date: Wed, 16 Nov 2016 12:36:12 +0000 [thread overview]
Message-ID: <3759a079-efcb-3a7b-2eaa-6ac07c57d1b6@linux.intel.com> (raw)
In-Reply-To: <20161116122618.22446-1-chris@chris-wilson.co.uk>
On 16/11/2016 12:26, Chris Wilson wrote:
> We don't spam the debug when we create a normal object, nor when we
> allocate their pages. Yet we do for stolen objects, and since these are
> quite frequently used (at least once per context), the resulting spam
> floods the dmesg in CI.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/i915_gem_stolen.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c b/drivers/gpu/drm/i915/i915_gem_stolen.c
> index 981796d7618c..55491234beda 100644
> --- a/drivers/gpu/drm/i915/i915_gem_stolen.c
> +++ b/drivers/gpu/drm/i915/i915_gem_stolen.c
> @@ -523,7 +523,6 @@ i915_pages_create_for_stolen(struct drm_device *dev,
> struct sg_table *st;
> struct scatterlist *sg;
>
> - DRM_DEBUG_DRIVER("offset=0x%x, size=%d\n", offset, size);
> GEM_BUG_ON(offset > dev_priv->ggtt.stolen_size - size);
>
> /* We hide that we have no struct page backing our stolen object
> @@ -625,7 +624,6 @@ i915_gem_object_create_stolen(struct drm_device *dev, u32 size)
> if (!drm_mm_initialized(&dev_priv->mm.stolen))
> return NULL;
>
> - DRM_DEBUG_KMS("creating stolen object: size=%x\n", size);
> if (size == 0)
> return NULL;
>
>
Yay!
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-11-16 12:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 12:26 [PATCH] drm/i915: Remove stolen object spam Chris Wilson
2016-11-16 12:36 ` Tvrtko Ursulin [this message]
2016-11-17 14:29 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3759a079-efcb-3a7b-2eaa-6ac07c57d1b6@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox