From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Michel Thierry <michel.thierry@intel.com>,
intel-gfx@lists.freedesktop.org, mika.kuoppala@linux.intel.com
Subject: Re: [RFC 2/3] drm/i915: Watchdog timeout: Ringbuffer command emission for gen8+
Date: Fri, 24 Feb 2017 09:15:26 +0000 [thread overview]
Message-ID: <39de8c14-be46-8499-062d-883a9ece544a@linux.intel.com> (raw)
In-Reply-To: <20170223210341.GG19577@nuc-i3427.alporthouse.com>
On 23/02/2017 21:03, Chris Wilson wrote:
> On Thu, Feb 23, 2017 at 11:44:18AM -0800, Michel Thierry wrote:
[snip]
>> +static int gen8_emit_stop_watchdog(struct drm_i915_gem_request *req)
>> +{
>> + struct intel_engine_cs *engine = req->engine;
>> + u32 *cs;
>> +
>> + cs = intel_ring_begin(req, 4);
>> + if (IS_ERR(cs))
>> + return PTR_ERR(cs);
>> +
>> + *cs++ = MI_LOAD_REGISTER_IMM(1);
>> + *cs++ = i915_mmio_reg_offset(RING_CNTR(engine->mmio_base));
>> +
>> + switch (engine->id) {
>> + default:
>> + WARN(1, "%s does not support watchdog timeout!\n",
>> + engine->name);
>> + /* default to render engine */
>
> Just
> GEM_BUG_ON(engine->id == BCS);
> if (engine->id == RCS)
> *cs++ = GEN8_RCS_WATCHDOG_DISABLE;
> else
> *cs++ = GEN8_XCS_WATCHDOG_DISABLE;
I'd go further and store it in the engine eg. "*cs++ =
engine->watchdog_disable_cmd" or something. I think that's better than
engines with identity crisis. :)
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-02-24 9:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 19:44 [RFC 1/3] drm/i915: Watchdog timeout: IRQ handler for gen8+ Michel Thierry
2017-02-23 19:44 ` [RFC 2/3] drm/i915: Watchdog timeout: Ringbuffer command emission " Michel Thierry
2017-02-23 21:03 ` Chris Wilson
2017-02-24 9:15 ` Tvrtko Ursulin [this message]
2017-02-23 19:44 ` [RFC 3/3] drm/i915: Watchdog timeout: DRM kernel interface to set the timeout Michel Thierry
2017-02-23 21:14 ` Chris Wilson
2017-02-23 19:44 ` [PATCH i-g-t 1/2] lib/igt_gt: Add watchdog gem_ctx_set_param ioctl interface Michel Thierry
2017-02-23 19:44 ` [PATCH i-g-t 2/2] tests/drv_hangman: watchdog tests Michel Thierry
2017-02-23 22:26 ` Chris Wilson
2017-02-23 23:06 ` Chris Wilson
2017-02-23 20:52 ` ✓ Fi.CI.BAT: success for series starting with [RFC,1/3] drm/i915: Watchdog timeout: IRQ handler for gen8+ Patchwork
2017-02-23 20:57 ` [RFC 1/3] " Chris Wilson
2017-02-23 21:21 ` Michel Thierry
2017-02-23 21:49 ` Chris Wilson
2017-02-23 22:12 ` Michel Thierry
2017-02-23 23:38 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39de8c14-be46-8499-062d-883a9ece544a@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michel.thierry@intel.com \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox