From: Tomi Sarvela <tomi.p.sarvela@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
Martin Peres <martin.peres@linux.intel.com>,
Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Enable refcount debugging for default debug levels
Date: Thu, 13 Jun 2019 15:57:19 +0300 [thread overview]
Message-ID: <3d6f1ecd-9923-89bb-4be8-d197f42c049f@intel.com> (raw)
In-Reply-To: <20190613124605.GH29428@intel.com>
On 6/13/19 3:46 PM, Rodrigo Vivi wrote:
> On Thu, Jun 13, 2019 at 01:28:42PM +0100, Chris Wilson wrote:
>> refcount_t is our first line of defence against use-after-free, so let's
>> enable it for debugging.
>
> It seems a nice thing to have on debug by default and they promise no
> performance impact.
>
> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Well, I hope our CI doesn't complain, but if it does we can remove later.
> anyway,
> Cc: Martin
> Cc: Tomi
> Cc: Arek
This change will be seen in forced build CI_DRM_6260.
Tomi
>>
>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> ---
>> drivers/gpu/drm/i915/Kconfig.debug | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
>> index 09aa0f4c8bf1..8d922bb4d953 100644
>> --- a/drivers/gpu/drm/i915/Kconfig.debug
>> +++ b/drivers/gpu/drm/i915/Kconfig.debug
>> @@ -21,6 +21,7 @@ config DRM_I915_DEBUG
>> depends on DRM_I915
>> select DEBUG_FS
>> select PREEMPT_COUNT
>> + select REFCOUNT_FULL
>> select I2C_CHARDEV
>> select STACKDEPOT
>> select DRM_DP_AUX_CHARDEV
>> --
>> 2.20.1
--
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-06-13 13:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 12:28 [PATCH] drm/i915: Enable refcount debugging for default debug levels Chris Wilson
2019-06-13 12:46 ` Rodrigo Vivi
2019-06-13 12:57 ` Tomi Sarvela [this message]
2019-06-14 10:02 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-06-15 6:46 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d6f1ecd-9923-89bb-4be8-d197f42c049f@intel.com \
--to=tomi.p.sarvela@intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=martin.peres@linux.intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox