Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: FNU VISHWANATHA <fnu.vishwanatha@intel.com>,
	dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org,
	FNU VISHWANATHA <fnu.vishwanatha@intel.com>
Subject: Re: [PATCH 1/2] drm/mst: Fix sporadic second display not detected after warm boot/G3
Date: Fri, 02 Oct 2026 12:21:19 +0300	[thread overview]
Message-ID: <3ddffda7b123f83a4dc94d26f299dec08da27fba@intel.com> (raw)
In-Reply-To: <20261001215705.3891147-1-fnu.vishwanatha@intel.com>

On Thu, 01 Oct 2026, FNU VISHWANATHA <fnu.vishwanatha@intel.com> wrote:
> The intermittent detection failure of the second display over MST HUB is caused
> by a race condition in MST port status detection during warm boot/G3 resume.
>
> When a port transitions from input to output state during topology reprobe, the
> driver was not forcing a re-probe of the link address. This caused ports that
> were temporarily incorrectly marked as input ports to never create connectors.
>
> Force a link address reprobe when a port transitions from input (1) to output
> (0) state, giving the MST hub another chance to properly report the port status.
>
> Signed-off-by: FNU VISHWANATHA <fnu.vishwanatha@intel.com>

Is there a bug report about this with logs?

> ---
>  drivers/gpu/drm/display/drm_dp_mst_topology.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> index be749dcad3b5..cc340e4235cc 100644
> --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> @@ -2377,7 +2377,11 @@ drm_dp_mst_handle_link_address_port(struct drm_dp_mst_branch *mstb,
>                 changed = true;
>                 created = true;
>         } else if (port->input && !port_msg->input_port) {
> +               /* Port transitioned from input to output (e.g., during warm boot/G3 resume)
> +                * We need to force link address reprobe to get proper port info
> +                */
>                 changed = true;
> +               mstb->link_address_sent = false;
>         } else if (port->connector) {
>                 /* We're updating a port that's exposed to userspace, so do it
>                  * under lock

-- 
Jani Nikula, Intel

      parent reply	other threads:[~2026-10-02  9:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-01 21:57 [PATCH 1/2] drm/mst: Fix sporadic second display not detected after warm boot/G3 FNU VISHWANATHA
2026-10-01 21:57 ` [PATCH 2/2] drm/i915/mst: Force link address reprobe after MST resume FNU VISHWANATHA
2026-10-02  9:23   ` Jani Nikula
2026-10-02  9:28     ` Jani Nikula
2026-10-01 22:37 ` ✗ Fi.CI.BUILD: failure for series starting with [1/2] drm/mst: Fix sporadic second display not detected after warm boot/G3 Patchwork
2026-10-02  9:21 ` Jani Nikula [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ddffda7b123f83a4dc94d26f299dec08da27fba@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fnu.vishwanatha@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox