From: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>
To: "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v1] drm/i915/gsc: take a wakeref for the proxy-init-completion check
Date: Thu, 8 Jun 2023 22:48:53 +0000 [thread overview]
Message-ID: <40affeb1a7b77c0abad8ad66f7820e249b993aa0.camel@intel.com> (raw)
In-Reply-To: <0c7cb50b-413d-c63a-985d-79e5b19bf016@intel.com>
On Thu, 2023-06-08 at 11:19 -0700, Ceraolo Spurio, Daniele wrote:
> On 6/8/2023 11:04 AM, Alan Previn wrote:
> > Ensure intel_gsc_uc_fw_init_done and intel_gsc_uc_fw_proxy_init
> > takes a wakeref before reading GSC Shim registers.
alan:snip
>
> > bool intel_gsc_uc_fw_proxy_init_done(struct intel_gsc_uc *gsc)
> > {
> > struct intel_uncore *uncore = gsc_uc_to_gt(gsc)->uncore;
> > - u32 fw_status = intel_uncore_read(uncore, GSC_FW_STATUS_REG);
> > + intel_wakeref_t wakeref;
> > + u32 fw_status;
> > +
> > + with_intel_runtime_pm(uncore->rpm, wakeref)
> > + fw_status = intel_uncore_read(uncore, GSC_FW_STATUS_REG);
>
> I think this could be moved to an helper (gsc_uc_get_fw_status?), so we
> don't have to re-do the wakeref in all the callers.
alan: thanks - will fix.
next prev parent reply other threads:[~2023-06-08 22:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 18:04 [Intel-gfx] [PATCH v1] drm/i915/gsc: take a wakeref for the proxy-init-completion check Alan Previn
2023-06-08 18:19 ` Ceraolo Spurio, Daniele
2023-06-08 22:48 ` Teres Alexis, Alan Previn [this message]
2023-06-08 19:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40affeb1a7b77c0abad8ad66f7820e249b993aa0.camel@intel.com \
--to=alan.previn.teres.alexis@intel.com \
--cc=daniele.ceraolospurio@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox