From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Cc: linux-renesas-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH igt 2/8] tests/kms_panel_fitting: check for i915 before checking version
Date: Tue, 20 Mar 2018 13:24:09 +0200 [thread overview]
Message-ID: <4326028.gVfV6JXNhJ@avalon> (raw)
In-Reply-To: <1521125144-28614-3-git-send-email-ulrich.hecht+renesas@gmail.com>
Hi Ulrich,
Thank you for the patch.
On Thursday, 15 March 2018 16:45:38 EET Ulrich Hecht wrote:
> Fixes false negatives on non-i915 platforms.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
> tests/kms_panel_fitting.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
> index b3cee22..6d0be50 100644
> --- a/tests/kms_panel_fitting.c
> +++ b/tests/kms_panel_fitting.c
> @@ -243,6 +243,7 @@ static void test_atomic_fastset(igt_display_t *display)
> igt_set_module_param_int("fastboot", 1);
>
> igt_require(display->is_atomic);
> + igt_require(is_i915_device(display->drm_fd));
> igt_require(intel_gen(intel_get_drm_devid(display->drm_fd)) >= 5);
I'm fine with this patch as a quick fix, but what in this test is Intel-
specific ? Can't we replace the Intel generation check with a different
feature check ?
> for_each_pipe_with_valid_output(display, pipe, output) {
--
Regards,
Laurent Pinchart
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-03-20 11:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 14:45 [PATCH igt 0/8] Non-Intel test suite fixes Ulrich Hecht
2018-03-15 14:45 ` [PATCH igt 1/8] tests/kms_addfb_basic: skip i915-specific tests on other platforms Ulrich Hecht
2018-03-16 8:51 ` Daniel Vetter
2018-03-20 11:24 ` Laurent Pinchart
2018-03-15 14:45 ` [PATCH igt 2/8] tests/kms_panel_fitting: check for i915 before checking version Ulrich Hecht
2018-03-16 8:51 ` Daniel Vetter
2018-03-20 11:24 ` Laurent Pinchart [this message]
2018-03-21 8:34 ` Daniel Vetter
2018-03-21 8:52 ` Laurent Pinchart
2018-03-27 6:41 ` Daniel Vetter
2018-03-15 14:45 ` [PATCH igt 3/8] lib/igt_gt: has_gpu_reset(): fix failed assertion on non-i915 platforms Ulrich Hecht
2018-03-15 17:28 ` Ville Syrjälä
2018-03-16 8:46 ` Daniel Vetter
2018-03-15 14:45 ` [PATCH igt 4/8] lib/igt_gt: check for presence of GPU reset before using it Ulrich Hecht
2018-03-15 14:45 ` [PATCH igt 5/8] tests/kms_plane_lowres: skip i915-specific tests on other platforms Ulrich Hecht
2018-03-15 17:33 ` Ville Syrjälä
2018-03-15 14:45 ` [PATCH igt 6/8] lib/igt_pm: turn absence of autosuspend_delay_ms from fail to skip Ulrich Hecht
2018-03-15 17:43 ` Ville Syrjälä
2018-03-15 14:45 ` [PATCH igt 7/8] tests/kms_addfb_basic: size_tests(): reduce test buffer size Ulrich Hecht
2018-03-16 8:53 ` Daniel Vetter
2018-03-15 14:45 ` [PATCH igt 8/8] test/kms_addfb_basic: tolerate absence of 8-bit format Ulrich Hecht
2018-03-16 8:49 ` Daniel Vetter
2018-03-15 15:03 ` ✗ Fi.CI.BAT: failure for Non-Intel test suite fixes Patchwork
2018-03-16 8:55 ` [PATCH igt 0/8] " Daniel Vetter
2018-03-19 16:41 ` Ulrich Hecht
2018-03-20 11:32 ` Laurent Pinchart
2018-03-21 8:37 ` Daniel Vetter
2018-04-27 16:03 ` Laurent Pinchart
2018-05-08 16:03 ` Ulrich Hecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4326028.gVfV6JXNhJ@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=ulrich.hecht+renesas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox