Re: [PATCH 1/6] drm/i915: Transform WaInPlaceDecompressionHang into a simple reg write

[Oscar Mateo <oscar.mateo@intel.com>]

On 09/07/2017 04:03 AM, Michał Winiarski wrote:
> On Wed, Sep 06, 2017 at 05:15:49PM -0700, Oscar Mateo wrote:
>> Afaict, GEN9_GAMT_ECO_REG_RW_IA does not live in the context, so writing
>> it on every context creation is overkill (and wrong).
>>
>> v2: Missing end parenthesis
> Though there was a discussion whether this belongs in init_workarounds, or
> init_clock_gating - I do believe that moving things around and/or renaming
> things is something that should be done in a separate patch.
>
> I compared modified registers with the spec. It all checks out.
> With the missing end parenthesis added (you're still missing some in a different
> patch ;) ), the whole series is:
>
> Reviewed-by: Michał Winiarski <michal.winiarski@intel.com>
>
> -Michał

Yes, I reached the same conclusion myself after seeing how many 
wrongly-applied WAs we had. I would still like to reach an agreement on 
the refactoring of the WA code, though, because the whole thing is very 
confusing as it stands now.

Thanks for the review!

-- Oscar

>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>
>> ---
>>   drivers/gpu/drm/i915/intel_engine_cs.c | 25 +++++++++++++++----------
>>   1 file changed, 15 insertions(+), 10 deletions(-)

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx