From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 10/16] drm/i915: Handle stolen objects for pread
Date: Sat, 01 Dec 2012 00:14:29 +0000 [thread overview]
Message-ID: <453bf0$6mibqr@azsmga001.ch.intel.com> (raw)
In-Reply-To: <CAKMK7uEHzCcXjwSGqsxYeUnaemLhagV9rHBdYkmnXcRaCa_OLg@mail.gmail.com>
On Sat, 1 Dec 2012 01:03:39 +0100, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Sat, Dec 1, 2012 at 12:46 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > On Fri, 30 Nov 2012 23:33:43 +0100, Daniel Vetter <daniel@ffwll.ch> wrote:
> >> On Thu, Nov 15, 2012 at 11:32:25AM +0000, Chris Wilson wrote:
> >> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >>
> >> Tbh I don't see any reason for handling pwrite/pread support for stolen
> >> mem backed objects. I'll leave these two patches here (plus the prep one
> >> to differentiate between stolen and dma_bufs) for now until a user pops
> >
> > The problem is that constitutes a change in ABI, so I was trying to make
> > sure stolen buffer objects were first class from day one. The only
> > saving grace is that userspace can only access the stolen object for
> > fbcon, but it is still available...
>
> Hm, I've forgotten that userspace can get at the fbcon. Does it really
> do that? The problem I see here is untested code and no sane way to
> test it.
Hint: the bogus obj->gtt_offset == 0 check was found experimentally. :)
No one pwrites/preads to the fbcon, today. If it makes you feel
any better, I would like to be able to create objects preferrentially
from stolen (e.g. scanouts) and you could build a test interface on top.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-12-01 12:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 11:32 Hopefully the last round of stolen work Chris Wilson
2012-11-15 11:32 ` [PATCH 01/16] drm: Introduce drm_mm_create_block() Chris Wilson
2012-11-15 11:32 ` [PATCH 02/16] drm: Introduce an iterator over holes in the drm_mm range manager Chris Wilson
2012-11-15 11:32 ` [PATCH 03/16] drm/i915: Fix detection of base of stolen memory Chris Wilson
2012-11-15 11:32 ` [PATCH 04/16] drm/i915: Avoid clearing preallocated regions from the GTT Chris Wilson
2012-11-15 11:32 ` [PATCH 05/16] drm/i915: Delay allocation of stolen space for FBC Chris Wilson
2012-11-15 11:32 ` [PATCH 06/16] drm/i915: Allow objects to be created with no backing pages, but stolen space Chris Wilson
2012-11-15 11:32 ` [PATCH 07/16] drm/i915: Differentiate between prime and stolen objects Chris Wilson
2012-11-15 11:32 ` [PATCH 08/16] drm/i915: Support readback of stolen objects upon error Chris Wilson
2012-11-15 11:32 ` [PATCH 09/16] drm/i915: Handle stolen objects in pwrite Chris Wilson
2012-11-15 11:32 ` [PATCH 10/16] drm/i915: Handle stolen objects for pread Chris Wilson
2012-11-30 22:33 ` Daniel Vetter
2012-11-30 23:46 ` Chris Wilson
2012-12-01 0:03 ` Daniel Vetter
2012-12-01 0:14 ` Chris Wilson [this message]
2012-11-15 11:32 ` [PATCH 11/16] drm/i915: Introduce i915_gem_object_create_stolen() Chris Wilson
2012-11-15 11:32 ` [PATCH 12/16] drm/i915: Allocate fbcon from stolen memory Chris Wilson
2012-11-15 11:32 ` [PATCH 13/16] drm/i915: Allocate ringbuffers " Chris Wilson
2012-11-15 11:32 ` [PATCH 14/16] drm/i915: Allocate overlay registers " Chris Wilson
2012-11-15 11:32 ` [PATCH 15/16] drm/i915: Use a slab for object allocation Chris Wilson
2012-11-30 22:45 ` Daniel Vetter
2012-11-15 11:32 ` [PATCH 16/16] drm/i915: Introduce mapping of user pages into video memory (userptr) ioctl Chris Wilson
2012-11-30 23:06 ` Daniel Vetter
2012-11-30 23:57 ` Chris Wilson
2012-12-01 11:25 ` Chris Wilson
2012-12-01 11:35 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='453bf0$6mibqr@azsmga001.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox