Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Mun, Gwan-gyeong" <gwan-gyeong.mun@intel.com>
To: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx]  ✗ Fi.CI.CHECKPATCH: warning for series starting with [v14,1/2] drm/i915/display: Support PSR Multiple Instances
Date: Tue, 2 Feb 2021 14:42:17 +0000	[thread overview]
Message-ID: <4567c9bb0cf3258d60211b853a4275e7fd3a161d.camel@intel.com> (raw)
In-Reply-To: <161192074533.15525.16707418211369763511@emeril.freedesktop.org>

On Fri, 2021-01-29 at 11:45 +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: series starting with [v14,1/2] drm/i915/display: Support PSR
> Multiple Instances
> URL   : https://patchwork.freedesktop.org/series/86445/
> State : warning
> 
> == Summary ==
> 
> $ dim checkpatch origin/drm-tip
> e7df7e13f87c drm/i915/display: Support PSR Multiple Instances
> -:88: ERROR:COMPLEX_MACRO: Macros with complex values should be
> enclosed in parentheses
> #88: FILE: drivers/gpu/drm/i915/display/intel_display.h:420:
> +#define for_each_intel_encoder_mask_can_psr(dev, intel_encoder,
> encoder_mask) \
> +       list_for_each_entry((intel_encoder), &(dev)-
> >mode_config.encoder_list, base.head) \
> +               for_each_if(((encoder_mask) &
> drm_encoder_mask(&(intel_encoder)->base)) && \
> +                           intel_encoder_can_psr(intel_encoder))
> 
> -:88: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'intel_encoder' -
> possible side-effects?
> #88: FILE: drivers/gpu/drm/i915/display/intel_display.h:420:
> +#define for_each_intel_encoder_mask_can_psr(dev, intel_encoder,
> encoder_mask) \
> +       list_for_each_entry((intel_encoder), &(dev)-
> >mode_config.encoder_list, base.head) \
> +               for_each_if(((encoder_mask) &
> drm_encoder_mask(&(intel_encoder)->base)) && \
> +                           intel_encoder_can_psr(intel_encoder))
> 
> -:97: ERROR:COMPLEX_MACRO: Macros with complex values should be
> enclosed in parentheses
> #97: FILE: drivers/gpu/drm/i915/display/intel_display.h:429:
> +#define for_each_intel_encoder_can_psr(dev, intel_encoder) \
> +       for_each_intel_encoder((dev), (intel_encoder)) \
> +               for_each_if(intel_encoder_can_psr(intel_encoder))
> 
> -:97: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'intel_encoder' -
> possible side-effects?
> #97: FILE: drivers/gpu/drm/i915/display/intel_display.h:429:
> +#define for_each_intel_encoder_can_psr(dev, intel_encoder) \
> +       for_each_intel_encoder((dev), (intel_encoder)) \
> +               for_each_if(intel_encoder_can_psr(intel_encoder))
> 
> -:375: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'intel_dp' -
> possible side-effects?
> #375: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:1795:
> +#define CAN_PSR(intel_dp)      (HAS_PSR(dp_to_i915(intel_dp)) && \
> +                                (intel_dp)->psr.sink_support && \
> +                                (intel_dp)->psr.source_support)
> 
> total: 2 errors, 0 warnings, 3 checks, 1730 lines checked
> 02d0fee29897 drm/i915/display: Support Multiple Transcoders' PSR
> status on debugfs
> 
> 

The reported error related code are followed other intel display.h's
macro style and it is intended code.

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2021-02-02 14:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-29 11:20 [Intel-gfx] [PATCH v14 1/2] drm/i915/display: Support PSR Multiple Instances Gwan-gyeong Mun
2021-01-29 11:20 ` [Intel-gfx] [PATCH v14 2/2] drm/i915/display: Support Multiple Transcoders' PSR status on debugfs Gwan-gyeong Mun
2021-01-29 11:45 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v14,1/2] drm/i915/display: Support PSR Multiple Instances Patchwork
2021-02-02 14:42   ` Mun, Gwan-gyeong [this message]
2021-01-29 11:47 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-01-29 12:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-29 16:58 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2021-01-29  7:45 [Intel-gfx] [PATCH v14 1/2] " Gwan-gyeong Mun
2021-01-29  9:05 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v14,1/2] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4567c9bb0cf3258d60211b853a4275e7fd3a161d.camel@intel.com \
    --to=gwan-gyeong.mun@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox