Re: [PATCH] drm/i915/psr: vbt.psr.enable is only for eDP panels

["Hogander, Jouni" <jouni.hogander@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1526 bytes --]

On Mon, 2024-10-21 at 14:10 +0530, Naladala, Ramanaidu wrote:

Hi Jouni,

On 10/21/2024 1:03 PM, Jouni Högander wrote:


We don't want to check vbt.psr.enable on DP Panel Replay as it is targeted

for eDP panel usage only.


Signed-off-by: Jouni Högander <jouni.hogander@intel.com><mailto:jouni.hogander@intel.com>

---

 drivers/gpu/drm/i915/display/intel_psr.c | 4 +++-

 1 file changed, 3 insertions(+), 1 deletion(-)


diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c

index 3b20325b3f6a..4176163ec19a 100644

--- a/drivers/gpu/drm/i915/display/intel_psr.c

+++ b/drivers/gpu/drm/i915/display/intel_psr.c

@@ -233,7 +233,9 @@ static bool psr_global_enabled(struct intel_dp *intel_dp)

        switch (intel_dp->psr.debug & I915_PSR_DEBUG_MODE_MASK) {

        case I915_PSR_DEBUG_DEFAULT:

                if (display->params.enable_psr == -1)

-                       return connector->panel.vbt.psr.enable;

+                       return intel_dp_is_edp(intel_dp) ?

+                               connector->panel.vbt.psr.enable :

+                               true;

LGTM,

Reviewed-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com<mailto:ramanaidu.naladala@intel.com>>

Thank you Ramanaidu for checking my patch. This is now pushed to drm-intel-next.

BR,

Jouni Högander


                return display->params.enable_psr;

        case I915_PSR_DEBUG_DISABLE:

                return false;


[-- Attachment #2: Type: text/html, Size: 3066 bytes --]