intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>
To: Nemesa Garg <nemesa.garg@intel.com>,
	<intel-gfx@lists.freedesktop.org>,
	<intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH 6/6] drm/i915/cursor: Allow joiner cursor fast path update
Date: Thu, 27 Aug 2026 15:16:35 +0530	[thread overview]
Message-ID: <477d5403-8df9-476a-9731-27b4eac0cea2@intel.com> (raw)
In-Reply-To: <20260821044755.2234490-7-nemesa.garg@intel.com>



On 8/21/2026 10:17 AM, Nemesa Garg wrote:
> The legacy cursor path forced all joiner updates to the
> slow path by checking joiner_pipes.
> Drop the condition so that joiner cursor updates can use
> the fast path.
> 
> v4: Trimmed to only the joiner_pipes gate drop. [Chaitanya]
> 

LGTM
Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>

> Assisted-by: Claude:claude-sonnet-4.6
> Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_cursor.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_cursor.c b/drivers/gpu/drm/i915/display/intel_cursor.c
> index dedb6f87359c..fbf0c9e143a1 100644
> --- a/drivers/gpu/drm/i915/display/intel_cursor.c
> +++ b/drivers/gpu/drm/i915/display/intel_cursor.c
> @@ -909,13 +909,10 @@ intel_legacy_cursor_update(struct drm_plane *_plane,
>   	 * PSR2 selective fetch also requires the slow path as
>   	 * PSR2 plane and transcoder registers can only be updated during
>   	 * vblank.
> -	 *
> -	 * FIXME joiner fastpath would be good
>   	 */
>   	if (!crtc_state->hw.active ||
>   	    intel_crtc_needs_modeset(crtc_state) ||
> -	    intel_crtc_needs_fastset(crtc_state) ||
> -	    crtc_state->joiner_pipes)
> +	    intel_crtc_needs_fastset(crtc_state))
>   		goto slow;
>   
>   	/*


  reply	other threads:[~2026-08-27  9:46 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21  4:47 [PATCH 0/6] Enable joiner cursor fast updates Nemesa Garg
2026-08-21  4:47 ` [PATCH 1/6] drm/i915/cursor: Check joiner cursor commit status Nemesa Garg
2026-08-27  9:45   ` Borah, Chaitanya Kumar
2026-08-21  4:47 ` [PATCH 2/6] drm/i915/cursor: Add helper to update cursor plane Nemesa Garg
2026-08-27  9:45   ` Borah, Chaitanya Kumar
2026-08-21  4:47 ` [PATCH 3/6] drm/i915/cursor: Handle secondary cursor state Nemesa Garg
2026-08-27  9:45   ` Borah, Chaitanya Kumar
2026-08-21  4:47 ` [PATCH 4/6] drm/i915/cursor: Program secondary cursor planes Nemesa Garg
2026-08-27  9:46   ` Borah, Chaitanya Kumar
2026-08-21  4:47 ` [PATCH 5/6] drm/i915/cursor: Schedule cursor unpin per joined pipe Nemesa Garg
2026-08-27  9:46   ` Borah, Chaitanya Kumar
2026-08-21  4:47 ` [PATCH 6/6] drm/i915/cursor: Allow joiner cursor fast path update Nemesa Garg
2026-08-27  9:46   ` Borah, Chaitanya Kumar [this message]
2026-08-21  5:49 ` ✓ i915.CI.BAT: success for Enable joiner cursor fast updates (rev6) Patchwork
2026-08-21  9:05 ` ✗ i915.CI.Full: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2026-08-18  8:42 [PATCH 0/6] Enable joiner cursor fast updates Nemesa Garg
2026-08-18  8:42 ` [PATCH 6/6] drm/i915/cursor: Allow joiner cursor fast path update Nemesa Garg
2026-07-06 11:56 [PATCH 0/6] Enable joiner cursor fast updates Nemesa Garg
2026-07-06 11:56 ` [PATCH 6/6] drm/i915/cursor: Allow joiner cursor fast path update Nemesa Garg
2026-06-08  6:26 [PATCH 0/6] Enable joiner cursor fast updates Nemesa Garg
2026-06-08  6:26 ` [PATCH 6/6] drm/i915/cursor: Allow joiner cursor fast path update Nemesa Garg
2026-07-01 16:31   ` Borah, Chaitanya Kumar
2026-04-28 14:16 [PATCH 0/6] Enable joiner cursor fast updates Nemesa Garg
2026-04-28 14:16 ` [PATCH 6/6] drm/i915/cursor: Allow joiner cursor fast path update Nemesa Garg
2026-04-22  7:37 [PATCH 0/6] Enable joiner cursor fast updates Nemesa Garg
2026-04-22  7:37 ` [PATCH 6/6] drm/i915/cursor: Allow joiner cursor fast path update Nemesa Garg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=477d5403-8df9-476a-9731-27b4eac0cea2@intel.com \
    --to=chaitanya.kumar.borah@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=nemesa.garg@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).