From: Adam Jackson <ajax@redhat.com>
To: "H. Peter Anvin" <hpa@kernel.org>
Cc: intel-gfx@lists.freedesktop.org, x86@kernel.org
Subject: Re: [PATCH 3/3] drm/i915: Don't do MTRR setup if PAT is enabled
Date: Tue, 13 Mar 2012 14:39:45 -0400 [thread overview]
Message-ID: <4F5F9471.10803@redhat.com> (raw)
In-Reply-To: <4F5F8B9C.1020208@kernel.org>
On 3/13/12 2:02 PM, H. Peter Anvin wrote:
> However, for the overall goal of the patch sequence, I think it is a
> good thing to not use MTRRs when PAT is available. Part of me is
> wondering if we shouldn't simply turn off the X86_FEATURE_PAT in
> boot_cpu_info when PAT is disabled.
It looks like the only user of cpu_has_pat is the PAT code itself, so
that should be safe in the sense of not breaking anyone's expectations.
And it would avoid needing to export another symbol. I like.
Will respin to do that, with better descriptions.
- ajax
prev parent reply other threads:[~2012-03-13 18:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 16:22 [PATCH 1/3] x86: EXPORT_SYMBOL(pat_enabled) Adam Jackson
2012-03-13 16:22 ` [PATCH 2/3] drm/i915: Pull MTRR setup to its own function Adam Jackson
2012-03-13 16:22 ` [PATCH 3/3] drm/i915: Don't do MTRR setup if PAT is enabled Adam Jackson
[not found] ` <4F5F8B9C.1020208@kernel.org>
2012-03-13 18:39 ` Adam Jackson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5F9471.10803@redhat.com \
--to=ajax@redhat.com \
--cc=hpa@kernel.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox