Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
To: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>,
	<intel-xe@lists.freedesktop.org>,
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/xe/guc: Fix kernel-doc warning in GuC scheduler ABI header
Date: Thu, 29 Jan 2026 10:23:56 -0800	[thread overview]
Message-ID: <4ca3a767-300b-4fbf-86cf-a50e172b060a@intel.com> (raw)
In-Reply-To: <20260129103730.2289942-1-chaitanya.kumar.borah@intel.com>



On 1/29/2026 2:37 AM, Chaitanya Kumar Borah wrote:
> The GuC scheduler ABI header contains a file-level comment that is not
> intended to document a kernel-doc symbol. Using kernel-doc comment
> syntax (/** */) triggers kernel-doc warnings.
>
> With "-Werror", this causes the build to fail. Convert the comment to a
> regular block comment.
>
> HDRTEST drivers/gpu/drm/xe/abi/guc_scheduler_abi.h
> Warning: drivers/gpu/drm/xe/abi/guc_scheduler_abi.h:11 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
>   * Generic defines required for registration with and submissions to the GuC
> 1 warnings as errors
> make[6]: *** [drivers/gpu/drm/xe/Makefile:377: drivers/gpu/drm/xe/abi/guc_scheduler_abi.hdrtest] Error 3
> make[5]: *** [scripts/Makefile.build:544: drivers/gpu/drm/xe] Error 2
> make[4]: *** [scripts/Makefile.build:544: drivers/gpu/drm] Error 2
> make[3]: *** [scripts/Makefile.build:544: drivers/gpu] Error 2
> make[2]: *** [scripts/Makefile.build:544: drivers] Error 2
> make[1]: *** [/home/kbuild2/kernel/Makefile:2088: .] Error 2
> make: *** [Makefile:248: __sub-make] Error 2

Given that this is a build fix, I think this patch needs a fixes tag:

Fixes: b0c5cf4f5917 ("drm/gt/guc: extract scheduler-related defines from 
guc_fwif.h")

With that:

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
> ---
>   drivers/gpu/drm/xe/abi/guc_scheduler_abi.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/abi/guc_scheduler_abi.h b/drivers/gpu/drm/xe/abi/guc_scheduler_abi.h
> index 513b22a87428..19ec89bf39c5 100644
> --- a/drivers/gpu/drm/xe/abi/guc_scheduler_abi.h
> +++ b/drivers/gpu/drm/xe/abi/guc_scheduler_abi.h
> @@ -8,7 +8,7 @@
>   
>   #include <linux/types.h>
>   
> -/**
> +/*
>    * Generic defines required for registration with and submissions to the GuC
>    * scheduler. Includes engine class/instance defines and context attributes
>    * (id, priority, etc)


  parent reply	other threads:[~2026-01-29 18:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-29 10:37 [PATCH] drm/xe/guc: Fix kernel-doc warning in GuC scheduler ABI header Chaitanya Kumar Borah
2026-01-29 13:31 ` ✓ i915.CI.BAT: success for " Patchwork
2026-01-29 17:18 ` [PATCH] " Lin, Shuicheng
2026-01-29 18:23 ` Daniele Ceraolo Spurio [this message]
2026-01-29 19:35 ` ✗ i915.CI.Full: failure for " Patchwork
2026-02-02 16:55 ` ✓ i915.CI.Full: success " Patchwork
2026-02-02 19:26 ` Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ca3a767-300b-4fbf-86cf-a50e172b060a@intel.com \
    --to=daniele.ceraolospurio@intel.com \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox