public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Sharma, Shashank" <shashank.sharma@intel.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	ML dri-devel <dri-devel@lists.freedesktop.org>,
	"Vetter, Daniel" <daniel.vetter@intel.com>
Subject: Re: [PATCH 1/4] drm: add picture aspect ratio flags
Date: Thu, 4 Aug 2016 15:46:09 +0530	[thread overview]
Message-ID: <4dc288d8-20e8-fa2b-0707-2f93dfe83cb6@intel.com> (raw)
In-Reply-To: <CACvgo53sWqTLRxM8YhMkPG1f7TXpE6d=tqRYTX48TW7L+GYZBA@mail.gmail.com>

Hello Emil,

Thanks for your time.

I have got mixed opinion on this.

IMHO we should expose them to userspace too, as UI agents like Hardware 
composer/X/Wayland must know what does these

flags means, so that they can display them on the end user screen (like 
settings menu)

But few people even think thats its too complex to be exposed to 
userspace agents.

So your suggestions are welcome.

Regards
Shashank

On 8/4/2016 3:12 PM, Emil Velikov wrote:
> On 3 August 2016 at 11:56, Shashank Sharma <shashank.sharma@intel.com> wrote:
>
>> --- a/include/uapi/drm/drm_mode.h
>> +++ b/include/uapi/drm/drm_mode.h
>> +
>> +/* Aspect ratio flag bitmask (4 bits 22:19) */
>> +#define DRM_MODE_FLAG_PARMASK                  (0x0F<<19)
>> +#define  DRM_MODE_FLAG_PARNONE \
>> +                       (DRM_MODE_PICTURE_ASPECT_NONE << 19)
>> +#define  DRM_MODE_FLAG_PAR4_3 \
>> +                       (DRM_MODE_PICTURE_ASPECT_4_3 << 19)
>> +#define  DRM_MODE_FLAG_PAR16_9 \
>> +                       (DRM_MODE_PICTURE_ASPECT_16_9 << 19)
>>
> Afaict all these flags are internal/implementation specific thus we
> shouldn't expose them to userspace. Right ?
>
> -Emil

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-08-04 10:16 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-03 10:56 [PATCH 0/4]: Picture aspect ratio support in DRM layer Shashank Sharma
2016-08-03 10:56 ` [PATCH 1/4] drm: add picture aspect ratio flags Shashank Sharma
2016-08-03 17:40   ` Sean Paul
2016-08-04  9:19     ` Sharma, Shashank
2016-08-04  9:42   ` Emil Velikov
2016-08-04 10:16     ` Sharma, Shashank [this message]
2016-08-04 10:36       ` [Intel-gfx] " Daniel Vetter
2016-08-04 13:05         ` Sharma, Shashank
2016-08-04 16:04           ` Daniel Vetter
2016-08-04 11:34       ` Emil Velikov
2016-08-04 13:15         ` Sharma, Shashank
2016-08-04 14:31           ` Emil Velikov
2016-08-04 16:09             ` Daniel Vetter
2016-08-05  3:37               ` [Intel-gfx] " Sharma, Shashank
2016-08-09 13:12                 ` Jose Abreu
2016-08-09 13:44                   ` [Intel-gfx] " Daniel Vetter
2016-08-09 13:57                     ` Sharma, Shashank
2016-08-18 10:15               ` Emil Velikov
2016-08-03 10:56 ` [PATCH 2/4] drm: Add aspect ratio parsing in DRM layer Shashank Sharma
2016-08-03 17:44   ` Sean Paul
2016-08-04  9:22     ` Sharma, Shashank
2016-08-03 10:56 ` [PATCH 3/4] video: Add new aspect ratios for HDMI 2.0 Shashank Sharma
2016-08-03 17:47   ` Sean Paul
2016-08-03 10:56 ` [PATCH 4/4] drm: Add and handle new aspect ratios in DRM layer Shashank Sharma
2016-08-03 17:47   ` [Intel-gfx] " Sean Paul
2016-08-03 11:08 ` ✗ Ro.CI.BAT: failure for : Picture aspect ratio support " Patchwork
2016-08-03 11:48 ` [PATCH 0/4]: " Daniel Vetter
2016-08-03 13:08   ` Jose Abreu
2016-08-03 15:47     ` Sharma, Shashank
2016-08-04 14:16       ` Jose Abreu
2016-08-04 14:29         ` Sharma, Shashank
2016-08-04 15:13           ` Jose Abreu
2016-08-03 15:33   ` Sharma, Shashank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4dc288d8-20e8-fa2b-0707-2f93dfe83cb6@intel.com \
    --to=shashank.sharma@intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox