Re: [PATCH 00/10] drm/i915/frontbuffer: Fix the intel_frontbuffer lifetime mess

[Jani Nikula <jani.nikula@linux.intel.com>]

On Mon, 06 Oct 2025, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The attempted piecemeal intel_frontbuffer split between
> i915 and xe is not good. Redo it with a bigger shovel.

Thanks so much for doing this. I've eyeballed the code a bunch of times,
but was never really able to figure out what to do.

Acked-by: Jani Nikula <jani.nikula@intel.com>

on the whole thing. I'll also try and have a closer look for a proper
R-b.

> Ville Syrjälä (10):
>   drm/i915/overlay: Drop the DIRTYFB flush
>   drm/i915/overlay: Switchj to intel_frontbuffer_flip()
>   drm/i915/frontbuffer: Nuke intel_frontbuffer_flip_{prepare,complete}()
>   drm/i915/frontbuffer: Turn intel_bo_flush_if_display() into a
>     frontbuffer operation
>   drm/i915/frontbuffer: Handle the dirtyfb cache flush inside
>     intel_frontbuffer_flush()
>   drm/i915/frontbuffef: Split fb_tracking.lock into two
>   drm/i915/frontbuffer: Extract intel_frontbuffer_ref()
>   drm/i915/frontbuffer: Add intel_frontbuffer::display
>   drm/i915/frontbuffer: Fix intel_frontbuffer lifetime handling
>   drm/i915/gem:
>     s/i915_gem_object_get_frontbuffer/i915_gem_object_frontbuffer_lookup/
>
>  drivers/gpu/drm/i915/Makefile                 |   1 +
>  drivers/gpu/drm/i915/display/intel_bo.c       |  40 +++--
>  drivers/gpu/drm/i915/display/intel_bo.h       |   8 +-
>  .../gpu/drm/i915/display/intel_display_core.h |   5 +-
>  .../drm/i915/display/intel_display_debugfs.c  |   3 -
>  drivers/gpu/drm/i915/display/intel_fb.c       |   1 -
>  .../gpu/drm/i915/display/intel_frontbuffer.c  | 149 +++---------------
>  .../gpu/drm/i915/display/intel_frontbuffer.h  |  18 +--
>  drivers/gpu/drm/i915/display/intel_overlay.c  |   6 +-
>  drivers/gpu/drm/i915/gem/i915_gem_object.c    |  16 +-
>  .../i915/gem/i915_gem_object_frontbuffer.c    | 103 ++++++++++++
>  .../i915/gem/i915_gem_object_frontbuffer.h    |  56 +++----
>  .../gpu/drm/i915/gem/i915_gem_object_types.h  |   2 +-
>  drivers/gpu/drm/i915/i915_drv.h               |   2 +
>  drivers/gpu/drm/i915/i915_gem.c               |   2 +
>  drivers/gpu/drm/i915/i915_vma.c               |   8 +-
>  .../gpu/drm/xe/compat-i915-headers/i915_vma.h |   2 -
>  drivers/gpu/drm/xe/display/intel_bo.c         |  60 +++++--
>  18 files changed, 258 insertions(+), 224 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/gem/i915_gem_object_frontbuffer.c

-- 
Jani Nikula, Intel