Re: Fwd: Re: Macbook Pro Retina display problems

[Francois Rigaut <frigaut@gmail.com>]

Daniel,

nope, the hack didn't succeed. No apparent change.
Francois

On Tue 07 Aug 2012 05:31:25 EST, Daniel Vetter wrote:
> On Mon, Aug 06, 2012 at 11:40:36PM +1000, Francois Rigaut wrote:
>> Daniel,
>>
>> On Mon, Aug 6, 2012 at 7:17 PM, Daniel Vetter <daniel@ffwll.ch
>> <mailto:daniel@ffwll.ch>> wrote:
>>
>>     On Mon, Aug 6, 2012 at 10:59 AM, Francois Rigaut <frigaut@gmail.com
>>     <mailto:frigaut@gmail.com>> wrote:
>>      > Daniel,
>>      >
>>      >
>>      > my bad for the dmesg. It's there:
>>      >
>>     http://maumae.net/retina/intel_corrupted_drm_debug/dmesg_intel_corrupted_drm_debug
>>      >
>>      > I took pictures with a camera, and uploaded them at
>>      > Small 800x600 versions:
>>      >
>>     http://maumae.net/retina/intel_corrupted_drm_debug/intel_corrupted_upper_left_small.jpg
>>      >
>>     http://maumae.net/retina/intel_corrupted_drm_debug/intel_corrupted_upper_right_small.jpg
>>      >
>>     <http://maumae.net/retina/intel_corrupted_drm_debug/intel_corrupted_upper_left_small.jpg>
>>      >
>>     http://maumae.net/retina/intel_corrupted_drm_debug/intel_corrupted_whole_screen_small.jpg
>>      >
>>     <http://maumae.net/retina/intel_corrupted_drm_debug/intel_corrupted_upper_left_small.jpg>
>>      > full resolution versions:
>>      >
>>     http://maumae.net/retina/intel_corrupted_drm_debug/intel_corrupted_upper_left.jpg
>>      >
>>     <http://maumae.net/retina/intel_corrupted_drm_debug/intel_corrupted_upper_left_small.jpg>
>>      >
>>     http://maumae.net/retina/intel_corrupted_drm_debug/intel_corrupted_upper_right.jpg
>>      >
>>     <http://maumae.net/retina/intel_corrupted_drm_debug/intel_corrupted_upper_left_small.jpg>
>>      >
>>     http://maumae.net/retina/intel_corrupted_drm_debug/intel_corrupted_whole_screen.jpg
>>      >
>>     <http://maumae.net/retina/intel_corrupted_drm_debug/intel_corrupted_upper_left_small.jpg>
>>      >
>>      > Otherwise, the display works and behave normally (it's not
>>     static, doesn't
>>      > flicker). I can interact normally with the GUI element, display
>>     stuff, it's
>>      > accelerated (I run compiz and window wiggle normally, I can play
>>     videos, I
>>      > have control of backlight, etc).
>>
>>     Wow, that's a pretty impressive light-show ;-) Are the wrong colors
>>     always wrong in this manner, or does it change from boot to boot?
>>
>>
>> everything (color and sync) are always wrong in the same manner.
>>
>> the last git version of intel_reg_dumper gives me:
>> with i915 loaded:
>> http://maumae.net/retina/intel_corrupted_drm_debug/ird_i915_loaded
>> with i915.die=1:
>> http://maumae.net/retina/intel_corrupted_drm_debug/ird_i915_not_loaded
>
> Can you please try the below quick hack. If that doesn't cut it, I need to
> improve the reg_dumper tool first, the efi firmware sets things up on pipe
> C, which we currently don't dump.
> -Daniel
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 0a56b9a..d7462da 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -920,9 +920,9 @@ intel_dp_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode,
>   	/* Split out the IBX/CPU vs CPT settings */
>
>   	if (is_cpu_edp(intel_dp) && IS_GEN7(dev)) {
> -		if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)
> +		//if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)
>   			intel_dp->DP |= DP_SYNC_HS_HIGH;
> -		if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
> +		//if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
>   			intel_dp->DP |= DP_SYNC_VS_HIGH;
>   		intel_dp->DP |= DP_LINK_TRAIN_OFF_CPT;