Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"j@metarealtyinc.ca" <j@metarealtyinc.ca>
Cc: "ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>,
	"Nikula,  Jani" <jani.nikula@intel.com>,
	"Manna, Animesh" <animesh.manna@intel.com>
Subject: Re: [PATCH v3] drm/i915/alpm: Add a quirk to keep the fast wake ahead of the IO buffer wake
Date: Mon, 7 Sep 2026 12:00:18 +0000	[thread overview]
Message-ID: <503d08599513b0670130aae64fa22f2a1a8f18b4.camel@intel.com> (raw)
In-Reply-To: <20260904133231.9028-1-j@metarealtyinc.ca>

On Fri, 2026-09-04 at 09:32 -0400, Jake Steinman wrote:
> On Fri, 2026-09-04 Jouni Högander wrote:
> > I think PSR2 was working on that setup at the point when I
> > introduced
> > that quirk
> > ...
> > Maybe this is actually matter of bisection?
> 
> Checked that today with a probe that only polls the sink (0x2006,
> 0x2008, 0x200a every 200 ms, error bit cleared after each read), so
> it
> runs the same on any kernel:
> 
>   stock 7.2.2, io/fast 11/11:    CRC error re-latched on every poll,
>                                  0x2008 = 3 throughout,
>                                  0x200a shows SU_VALID in 2 of 94
> polls
>   7.3-rc1, io/fast 11/11:        same, SU_VALID in 7 of 90 polls
>   7.3-rc1, io/fast 11/12:        no CRC errors, 0x2008 = 2,
>                                  SU_VALID never
> 
> So what looks like PSR2 working is the link failing on every wake and
> the engine re-entering over and over. Each re-entry does its two
> entry
> captures, those carry SU_VALID, then the engine parks in SU_STANDBY
> until the next failed wake resets it. Screen updates come from the
> resyncs, not from selective updates. With the wake clean there are no
> resyncs and the panel stays on the stale frame.
> 
> I doubt bisecting finds anything for PSR2: it was in this state in
> April too unless the wake formulas were different then, and
> intel_alpm.c has four commits since March, none touching them. Panel
> Replay uses the aux-less wake, which does not fail, so it froze
> outright from the start. That is the quirk.
> 
> Probe script and logs are on 9119.

Is PSR2 working on your setup with this quirk?

BR,
Jouni Högander

> 
> Jake


  reply	other threads:[~2026-09-07 12:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02 16:25 [PATCH] drm/i915/alpm: Keep the extended fast wake ahead of the IO buffer wake Jake Steinman
2026-09-03  4:11 ` Hogander, Jouni
2026-09-03 13:14 ` Jake Steinman
2026-09-03 13:17 ` [PATCH v2] drm/i915/alpm: Add a quirk to keep the " Jake Steinman
2026-09-03 16:14   ` sashiko-bot
2026-09-04  0:43   ` [PATCH v3] " Jake Steinman
2026-09-04  4:47     ` Hogander, Jouni
2026-09-04 11:48     ` Jake Steinman
2026-09-04 12:51       ` Hogander, Jouni
2026-09-04 13:32       ` Jake Steinman
2026-09-07 12:00         ` Hogander, Jouni [this message]
2026-09-07 13:12         ` Jake Steinman
2026-09-03 16:22 ` ✗ LGCI.VerificationFailed: failure for drm/i915/alpm: Keep the extended " Patchwork
2026-09-08 20:16 ` ✗ LGCI.VerificationFailed: failure for drm/i915/alpm: Keep the extended fast wake ahead of the IO buffer wake (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=503d08599513b0670130aae64fa22f2a1a8f18b4.camel@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=j@metarealtyinc.ca \
    --cc=jani.nikula@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox