Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: ✗ Fi.CI.CHECKPATCH: warning for Add new general DRM property "color format" (rev2)
Date: Mon, 01 Dec 2025 08:40:31 +0100	[thread overview]
Message-ID: <5077723.31r3eYUQgx@workhorse> (raw)
In-Reply-To: <176436598285.39153.14578789056730747031@a3b018990fe9>

On Friday, 28 November 2025 22:39:42 Central European Standard Time Patchwork wrote:
> == Series Details ==
> 
> Series: Add new general DRM property "color format" (rev2)
> URL   : https://patchwork.freedesktop.org/series/157910/
> State : warning

I will fix most of these (I guess the CI uses a different checkpatch
preset than b4 prep --check, had only one of these) but there's
three that I won't address because they're stupid:

> 
> == Summary ==
> 
> [snip]
> b979329d91af drm/bridge: Act on the DRM color format property
> -:73: WARNING:ENOTSUPP: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
> #73: FILE: drivers/gpu/drm/drm_bridge.c:1182:
> +			ret = -ENOTSUPP;
> 
> total: 0 errors, 1 warnings, 0 checks, 57 lines checked

The whole point of using -ENOTSUPP here is that it's the same return
code as other branches in drm_atomic_bridge_chain_select_bus_fmts
already take, and the caller already handles.

> [snip]
> 943216634f10 drm/tests: hdmi: Add tests for the color_format property
> -:90: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
> #90: FILE: drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c:2036:
> +	priv = drm_kunit_helper_connector_hdmi_init_with_edid_funcs(test,
> +				BIT(HDMI_COLORSPACE_RGB) |
> [snip]
> -:133: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
> #133: FILE: drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c:2079:
> +	priv = drm_kunit_helper_connector_hdmi_init_with_edid_funcs(test,
> +				BIT(HDMI_COLORSPACE_RGB) |
> 
> total: 0 errors, 0 warnings, 4 checks, 150 lines checked
> 

This is a big "no" from me. I'm not going to align stuff to the
opening brace when function names are so long they take up almost
the entire line, and it seems every other invocation in this file
agrees with me here.




      parent reply	other threads:[~2025-12-01  7:40 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-28 21:05 [PATCH v5 00/17] Add new general DRM property "color format" Nicolas Frattaroli
2025-11-28 21:05 ` [PATCH v5 01/17] drm/amd/display: Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check Nicolas Frattaroli
2025-11-28 21:05 ` [PATCH v5 02/17] drm: Add new general DRM property "color format" Nicolas Frattaroli
2025-12-09 14:11   ` Maxime Ripard
2025-11-28 21:05 ` [PATCH v5 03/17] drm: Add enum conversion from DRM_COLOR_FORMAT to HDMI_COLORSPACE Nicolas Frattaroli
2025-12-09 14:12   ` Maxime Ripard
2025-11-28 21:05 ` [PATCH v5 04/17] drm/bridge: Act on the DRM color format property Nicolas Frattaroli
2025-12-09 14:27   ` Maxime Ripard
2025-12-11 19:34     ` Nicolas Frattaroli
2025-12-12  9:50       ` Maxime Ripard
2025-12-12 14:45         ` Nicolas Frattaroli
2025-11-28 21:05 ` [PATCH v5 05/17] drm/display: hdmi-state-helper: Act on color format DRM property Nicolas Frattaroli
2025-12-09 14:16   ` Maxime Ripard
2025-12-11 19:42     ` Nicolas Frattaroli
2025-12-12  9:20       ` Maxime Ripard
2025-11-28 21:05 ` [PATCH v5 06/17] drm/display: hdmi-state-helper: Try subsampling in mode_valid Nicolas Frattaroli
2025-12-09 14:18   ` Maxime Ripard
2025-12-11 19:59     ` Nicolas Frattaroli
2025-12-12  9:29       ` Maxime Ripard
2025-11-28 21:05 ` [PATCH v5 07/17] drm/i915: Implement the "color format" DRM property Nicolas Frattaroli
2025-11-28 21:05 ` [PATCH v5 08/17] drm/amdgpu: Implement " Nicolas Frattaroli
2025-11-28 21:05 ` [PATCH v5 09/17] drm/rockchip: Add YUV422 output mode constants for VOP2 Nicolas Frattaroli
2025-11-28 21:05 ` [PATCH v5 10/17] drm/rockchip: vop2: Fix YUV444 output Nicolas Frattaroli
2025-11-28 21:05 ` [PATCH v5 11/17] drm/rockchip: vop2: Add RK3576 to the RG swap special case Nicolas Frattaroli
2025-11-28 21:05 ` [PATCH v5 12/17] drm/rockchip: vop2: Recognise 10/12-bit YUV422 as YUV formats Nicolas Frattaroli
2025-11-28 21:05 ` [PATCH v5 13/17] drm/rockchip: vop2: Set correct output format for RK3576 YUV422 Nicolas Frattaroli
2025-11-28 21:05 ` [PATCH v5 14/17] drm/rockchip: dw_hdmi_qp: Implement "color format" DRM property Nicolas Frattaroli
2025-11-28 21:05 ` [PATCH v5 15/17] drm/rockchip: dw_hdmi_qp: Set supported_formats platdata Nicolas Frattaroli
2025-11-28 21:05 ` [PATCH v5 16/17] drm/connector: Register color format property on HDMI connectors Nicolas Frattaroli
2025-12-09 14:22   ` Maxime Ripard
2025-11-28 21:05 ` [PATCH v5 17/17] drm/tests: hdmi: Add tests for the color_format property Nicolas Frattaroli
2025-12-12  9:19   ` Maxime Ripard
2025-12-12 20:28     ` Nicolas Frattaroli
2025-11-28 22:12 ` ✓ i915.CI.BAT: success for Add new general DRM property "color format" (rev2) Patchwork
2025-11-28 23:16 ` ✗ i915.CI.Full: failure " Patchwork
     [not found] ` <176436598285.39153.14578789056730747031@a3b018990fe9>
2025-12-01  7:40   ` Nicolas Frattaroli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5077723.31r3eYUQgx@workhorse \
    --to=nicolas.frattaroli@collabora.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox