Re: [PATCH v2 0/3] Make DRM DSC helpers more generally usable

["Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

Am 21.02.19 um 21:19 schrieb David Francis:
> drm_dsc could use some work so that drm drivers other than
> i915 can make use of it their own DSC implementations
>
> Move rc compute, a function that forms part of the DSC spec,
> into drm. Update it to DSC 1.2. Also split the PPS packing and
> SDP header init functions, to allow for drivers with
> their own SDP struct headers
>
> Re-sending due to Mail Delivery System errors

I have to admit that I know absolutely nothing about the technical 
background of the implemented spec.

But from a high level view it makes complete sense to have stuff which 
implements a spec in common code. Additional to that coding style etc 
seems to be ok on first glance.

So series is Acked-by: Christian König <christian.koenig@amd.com>

Regards,
Christian.

>
> v2:
> Rebase onto drm-next
> Refactor drm_dsc_dp_pps_header_init
> Clean up documentation on new drm function
>
> David Francis (3):
>    drm/i915: Move dsc rate params compute into drm
>    drm/dsc: Add native 420 and 422 support to compute_rc_params
>    drm/dsc: Split DSC PPS and SDP header initialisations
>
>   drivers/gpu/drm/drm_dsc.c         | 269 +++++++++++++++++++++++-------
>   drivers/gpu/drm/i915/intel_vdsc.c | 133 +--------------
>   include/drm/drm_dsc.h             |   9 +-
>   3 files changed, 219 insertions(+), 192 deletions(-)
>

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx