From: Adam Jackson <ajax@redhat.com>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH 3/3] drm/i915: fix FDI lane calculation
Date: Thu, 29 Nov 2012 11:16:04 -0500 [thread overview]
Message-ID: <50B78A44.6090109@redhat.com> (raw)
In-Reply-To: <1354195773-4022-3-git-send-email-przanoni@gmail.com>
On 11/29/12 8:29 AM, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> The previous code was making the bps value 5% higher than what the
> spec says, which was enough to make certain VGA modes require 3 lanes
> instead of 2, which makes us reject these modes on Haswell since it
> only has 2 FDI lanes. For previous gens this was not much of a
> problem, since they had 4 lanes, and requiring more lanes than the
> needed is ok, as long as you have all the lanes.
>
> Notice that this might improve the case where we use pipes B and C on
> Ivy Bridge since both pipes only have 4 lanes to share (see
> ironlake_check_fdi_lanes).
Fine with me. I'm not entirely sure the SS check I had there was
necessary; I do remember the docs saying to account for it, but I'm not
sure the check we had there was correct.
Reviewed-by: Adam Jackson <ajax@redhat.com>
- ajax
next prev parent reply other threads:[~2012-11-29 16:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 13:29 [PATCH 1/3] drm/i915: fix hsw_fdi_link_train "retry" code Paulo Zanoni
2012-11-29 13:29 ` [PATCH 2/3] drm/i915: reject modes the LPT FDI receiver can't handle Paulo Zanoni
2012-12-08 13:00 ` Daniel Vetter
2012-11-29 13:29 ` [PATCH 3/3] drm/i915: fix FDI lane calculation Paulo Zanoni
2012-11-29 13:59 ` Chris Wilson
2012-11-29 16:16 ` Adam Jackson [this message]
2012-11-29 21:54 ` [PATCH 1/3] drm/i915: fix hsw_fdi_link_train "retry" code Daniel Vetter
2012-11-30 15:39 ` Paulo Zanoni
2012-11-30 15:46 ` Daniel Vetter
2012-12-08 12:59 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B78A44.6090109@redhat.com \
--to=ajax@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox