From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/i915/display: shorten the intel_display_irq_regs_* function names
Date: Tue, 11 Nov 2025 10:07:53 +0200 [thread overview]
Message-ID: <52c2fda576e985430b3503e8051a2f3acd7e0ee3@intel.com> (raw)
In-Reply-To: <aRJLuIJlD1wsIBDn@intel.com>
On Mon, 10 Nov 2025, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Mon, Nov 10, 2025 at 09:31:39PM +0200, Jani Nikula wrote:
>> Shorten the intel_display_irq_regs_* function names to the underlying
>> function names with a _wl suffix for clarity.
>>
>> - intel_display_irq_regs_init() -> irq_init_wl()
>> - intel_display_irq_regs_reset() -> irq_reset_wl()
>> - intel_display_irq_regs_assert_irr_is_zero() -> assert_iir_is_zero_wl()
>>
>> This emphasizes the difference is the wakelock. Platforms without the
>> DMC wakelock mechanism can use the non-wl versions.
>
> These things should just get nuked. You already switched to
> intel_de_{read,write}() in the previous patch, and those already
> handle the wakelock stuff for you.
Oh where's my brown paper bag when I need it.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2025-11-11 8:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 19:31 [PATCH 0/4] drm/{i915, xe}/irq: clarify display and parent driver interfaces Jani Nikula
2025-11-10 19:31 ` [PATCH 1/4] drm/{i915, xe}/display: move irq calls to parent interface Jani Nikula
2025-11-10 20:31 ` [PATCH 1/4] drm/{i915,xe}/display: " Ville Syrjälä
2025-11-11 7:39 ` Jani Nikula
2025-11-10 19:31 ` [PATCH 2/4] drm/{i915, xe}/display: duplicate gen2 irq/error init/reset in display irq Jani Nikula
2025-11-10 19:31 ` [PATCH 3/4] drm/i915/display: convert the display irq interfaces to struct intel_display Jani Nikula
2025-11-10 19:31 ` [PATCH 4/4] drm/i915/display: shorten the intel_display_irq_regs_* function names Jani Nikula
2025-11-10 20:31 ` Ville Syrjälä
2025-11-11 8:07 ` Jani Nikula [this message]
2025-11-10 21:57 ` ✓ i915.CI.BAT: success for drm/{i915, xe}/irq: clarify display and parent driver interfaces Patchwork
2025-11-11 4:43 ` ✓ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52c2fda576e985430b3503e8051a2f3acd7e0ee3@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox