Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Arun R Murthy <arun.r.murthy@intel.com>,
	uma.shankar@intel.com, suraj.kandpal@intel.com,
	ankit.k.nautiyal@intel.com
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	Arun R Murthy <arun.r.murthy@intel.com>
Subject: Re: [PATCH v3 2/2] drm/i915/lt_phy_regs: Add SoC/OS turnaround time
Date: Mon, 23 Feb 2026 12:38:22 +0200	[thread overview]
Message-ID: <533398a623295fccc3f1053d28b2357dbf7e6fb1@intel.com> (raw)
In-Reply-To: <20260216-timeout-v3-2-055522c22560@intel.com>

On Mon, 16 Feb 2026, Arun R Murthy <arun.r.murthy@intel.com> wrote:
> On top the timeouts mentioned in the spec which includes only the PHY
> timeouts include the SoC and the OS turnaround time.
> The overhead value is based on the stress test results with multiple
> available panels.
>
> Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
> Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_lt_phy_regs.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_lt_phy_regs.h b/drivers/gpu/drm/i915/display/intel_lt_phy_regs.h
> index 37e46fb9abde4156ebd7ad1eb6cbbc12e7026b23..ff6d7829dbb9c50b2001d079b435b894faf9659e 100644
> --- a/drivers/gpu/drm/i915/display/intel_lt_phy_regs.h
> +++ b/drivers/gpu/drm/i915/display/intel_lt_phy_regs.h
> @@ -6,12 +6,12 @@
>  #ifndef __INTEL_LT_PHY_REGS_H__
>  #define __INTEL_LT_PHY_REGS_H__
>  
> -#define XE3PLPD_MSGBUS_TIMEOUT_FAST_US	500
> +#define XE3PLPD_MSGBUS_TIMEOUT_FAST_US		500
>  #define XE3PLPD_MACCLK_TURNON_LATENCY_MS	2
> -#define XE3PLPD_MACCLK_TURNOFF_LATENCY_US	1
> +#define XE3PLPD_MACCLK_TURNOFF_LATENCY_US	10
>  #define XE3PLPD_RATE_CALIB_DONE_LATENCY_MS	1
> -#define XE3PLPD_RESET_START_LATENCY_US	10
> -#define XE3PLPD_PWRDN_TO_RDY_LATENCY_US	4
> +#define XE3PLPD_RESET_START_LATENCY_US		10
> +#define XE3PLPD_PWRDN_TO_RDY_LATENCY_US		10
>  #define XE3PLPD_RESET_END_LATENCY_MS		2

Side note, *none* of these belong in intel_lt_phy_regs.h. They should be
moved to intel_lt_phy.c instead.

The timeouts do not describe the register contents.

BR,
Jani.


>  
>  /* LT Phy MAC Register */

-- 
Jani Nikula, Intel

  reply	other threads:[~2026-02-23 10:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-16  4:59 [PATCH v3 0/2] Update the PHY timeouts Arun R Murthy
2026-02-16  4:59 ` [PATCH v3 1/2] drm/i915/cx0_phy_regs: Include SoC and OS turnaround time Arun R Murthy
2026-02-23 10:37   ` Jani Nikula
2026-02-24  2:41     ` Kandpal, Suraj
2026-02-16  4:59 ` [PATCH v3 2/2] drm/i915/lt_phy_regs: Add SoC/OS " Arun R Murthy
2026-02-23 10:38   ` Jani Nikula [this message]
2026-02-16  6:51 ` ✓ i915.CI.BAT: success for Update the PHY timeouts (rev3) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533398a623295fccc3f1053d28b2357dbf7e6fb1@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=arun.r.murthy@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=suraj.kandpal@intel.com \
    --cc=uma.shankar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox