From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Michal Wajdeczko <michal.wajdeczko@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [RFC 4/4] drm/i915/uc: Add sanitize to to intel_uc_ops
Date: Wed, 11 Dec 2019 16:13:07 -0800 [thread overview]
Message-ID: <548f2efb-4f0d-e49b-8bd3-e881c4f3ad1d@intel.com> (raw)
In-Reply-To: <157601163956.17013.379009805423126881@skylake-alporthouse-com>
On 12/10/19 1:00 PM, Chris Wilson wrote:
> Quoting Michal Wajdeczko (2019-12-10 20:47:44)
>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.h b/drivers/gpu/drm/i915/gt/uc/intel_uc.h
>> index 2bd8326130f1..3410d35f8b0c 100644
>> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.h
>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.h
>> @@ -19,6 +19,7 @@ struct intel_uc_ops {
>> void (*fini)(struct intel_uc *uc);
>> int (*init_hw)(struct intel_uc *uc);
>> void (*fini_hw)(struct intel_uc *uc);
>> + int (*sanitize)(struct intel_uc *uc);
>
> In the order of ops, first?
>
> The series looks sane. Looks a bit overkill, but if you can convince
> Daniele of your vision, fine by me.
> -Chris
>
I've had a quick chat with Michal about this and, when also considering
some of the upcoming stuff, it does definitely make sense to me to
switch to ops.
Daniele
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-12 0:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 20:47 [Intel-gfx] [RFC 0/4] Add ops to intel_uc Michal Wajdeczko
2019-12-10 20:47 ` [Intel-gfx] [RFC 1/4] drm/i915/uc: " Michal Wajdeczko
2019-12-10 20:55 ` Chris Wilson
2019-12-10 21:02 ` Michal Wajdeczko
2019-12-10 21:04 ` Chris Wilson
2019-12-12 0:23 ` Daniele Ceraolo Spurio
2019-12-12 21:53 ` Michal Wajdeczko
2019-12-12 23:38 ` Daniele Ceraolo Spurio
2019-12-10 20:47 ` [Intel-gfx] [RFC 2/4] drm/i915/uc: Add init_fw/fini_fw to to intel_uc_ops Michal Wajdeczko
2019-12-10 20:52 ` Chris Wilson
2019-12-10 20:47 ` [Intel-gfx] [RFC 3/4] drm/i915/uc: Add init/fini " Michal Wajdeczko
2019-12-10 20:47 ` [Intel-gfx] [RFC 4/4] drm/i915/uc: Add sanitize " Michal Wajdeczko
2019-12-10 21:00 ` Chris Wilson
2019-12-12 0:13 ` Daniele Ceraolo Spurio [this message]
2019-12-11 4:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add ops to intel_uc Patchwork
2019-12-11 5:21 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548f2efb-4f0d-e49b-8bd3-e881c4f3ad1d@intel.com \
--to=daniele.ceraolospurio@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox