From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/skl: Fix up positive error code
Date: Tue, 24 Mar 2015 17:21:35 +0000 [thread overview]
Message-ID: <55119D1F.2030009@linux.intel.com> (raw)
In-Reply-To: <87h9tatpyq.fsf@intel.com>
On 03/24/2015 02:44 PM, Jani Nikula wrote:
> On Tue, 24 Mar 2015, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
>> On 03/24/2015 01:16 PM, Jani Nikula wrote:
>>> On Tue, 24 Mar 2015, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
>>>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>>
>>>> It should have been negative since it is returned with ERR_PTR().
>>>
>>> Please always reference the commit that introduced the issue.
>>
>> Is there some more precisely defined criteria for "always"?
>
> Always when you fix a bug that was introduced by another commit?
>
> I need the commit reference to check if I need to queue the fix to
> current development kernel (i.e. v4.0-rcN).
>
> If someone backports the commit, it's easier to check if the commit is
> referenced by a later commit potentially fixing issues in it.
Sure, but all bugs are introduced by other commits. So my question was
only along those lines, nothing more than that.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-24 17:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 11:18 [PATCH] drm/i915/skl: Fix up positive error code Tvrtko Ursulin
2015-03-24 13:16 ` Jani Nikula
2015-03-24 14:11 ` Tvrtko Ursulin
2015-03-24 14:44 ` Jani Nikula
2015-03-24 17:21 ` Tvrtko Ursulin [this message]
2015-03-25 13:33 ` Daniel Vetter
2015-03-24 16:50 ` shuang.he
2015-03-25 10:15 ` [PATCH v2] " Tvrtko Ursulin
2015-03-25 10:19 ` shuang.he
2015-03-25 13:34 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55119D1F.2030009@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox