Re: [PATCH 3/5] drm/i915/dsi: Make 'clock_stop' boolean

[Jani Nikula <jani.nikula@linux.intel.com>]

On Thu, 26 Mar 2026, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Thu, Mar 26, 2026 at 03:40:56PM +0200, Jani Nikula wrote:
>> On Thu, 26 Mar 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
>> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> >
>> > The DSI 'clock_stop' parameter is a boolean, so use a real
>> > 'bool' for it. And pimp the debug print while at it.
>> >
>> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> > ---
>> >  drivers/gpu/drm/i915/display/intel_dsi.h     | 2 +-
>> >  drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 4 ++--
>> >  2 files changed, 3 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/display/intel_dsi.h b/drivers/gpu/drm/i915/display/intel_dsi.h
>> > index 8e39d2b52c54..0023ac341aa0 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_dsi.h
>> > +++ b/drivers/gpu/drm/i915/display/intel_dsi.h
>> > @@ -81,7 +81,7 @@ struct intel_dsi {
>> >  	int video_mode;
>> >  
>> >  	bool eot_pkt;
>> > -	u8 clock_stop;
>> > +	bool clock_stop;
>> >  
>> >  	u8 escape_clk_div;
>> >  	u8 dual_link;
>> > diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
>> > index 51f6a5b82cb2..23da7f5f9578 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
>> > +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
>> > @@ -719,7 +719,7 @@ void intel_dsi_log_params(struct intel_dsi *intel_dsi)
>> >  	drm_printf(&p, "Burst mode ratio %d\n", intel_dsi->burst_mode_ratio);
>> >  	drm_printf(&p, "Reset timer %d\n", intel_dsi->rst_timer_val);
>> >  	drm_printf(&p, "EoT packet %s\n", str_enabled_disabled(intel_dsi->eot_pkt));
>> > -	drm_printf(&p, "Clockstop %s\n", str_enabled_disabled(!intel_dsi->clock_stop));
>> > +	drm_printf(&p, "Clock stop during BLLP %s\n", str_enabled_disabled(intel_dsi->clock_stop));
>> 
>> What's with the reversed !intel_dsi->clock_stop in the existing log and
>> the change here?
>
> I've had these sitting around for a while so completely forgot I changed
> it.
>
> Looks that it's been wrong since the initial commit.
>
> Apparently v2 of the patch
> https://lore.kernel.org/intel-gfx/1397454507-10273-5-git-send-email-shobhit.kumar@intel.com/
> had it the correct way around, but then it got messed in
> in v3 while the capital letters were being made lowercase.
>
> I can split that out into its own patch with that explanation.

Not sure I care enough, other than please mention it in the commit
message. Unless you specifically want that fix backported too.

BR,
Jani.


>
>> 
>> >  	drm_printf(&p, "Mode %s\n", intel_dsi->operation_mode ? "command" : "video");
>> >  	if (intel_dsi->dual_link == DSI_DUAL_LINK_FRONT_BACK)
>> >  		drm_printf(&p, "Dual link: DSI_DUAL_LINK_FRONT_BACK\n");
>> > @@ -771,7 +771,7 @@ bool intel_dsi_vbt_init(struct intel_dsi *intel_dsi, u16 panel_id)
>> >  	drm_dbg_kms(display->drm, "\n");
>> >  
>> >  	intel_dsi->eot_pkt = !mipi_config->eot_pkt_disabled;
>> > -	intel_dsi->clock_stop = mipi_config->enable_clk_stop ? 1 : 0;
>> > +	intel_dsi->clock_stop = mipi_config->enable_clk_stop;
>> >  	intel_dsi->lane_count = mipi_config->lane_cnt + 1;
>> >  	intel_dsi->pixel_format =
>> >  		vbt_to_dsi_pixel_format(mipi_config->videomode_color_format);
>> 
>> -- 
>> Jani Nikula, Intel

-- 
Jani Nikula, Intel