Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>
To: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v1 1/3] drm/i915/guc: Flush context destruction worker at suspend
Date: Tue, 15 Aug 2023 00:49:30 +0000	[thread overview]
Message-ID: <55de694c85fe97cb616682b97e76a4e36e5d1abf.camel@intel.com> (raw)
In-Reply-To: <d3231f39c1ff7d5899d4fd194ebed480e1cda1af.camel@intel.com>

> 

> > Rodrigo: And why here and not some upper layer? like in prepare....
> alan: wait_for_suspend does both the checking for idle as well as the potential
> wedging if guc or hw has hung at this late state. if i call from the upper
> layer before this wait_for_suspend, it might be too early because the
> wait-for-idle could experience workloads completing and new contexts-derigtrations
> being queued. If i call it from upper layer after wait_for_suspend, then it would
> be unnecessary if wait_for_suspend decided to nuke everything. Hmmm.. but i guess
> the latter could work too - since the nuke case would have emptied out the link-list
> of that worker and so it would either run and do nothing or would not even be queued.
> Would you rather i go that way? (i'll recheck with my team mates for i-dotting/t-crossing
> discussion.

actually, after going up a layer, i realize the right place might be to insert
late stage worker-flushing into intel_uc_suspend (called from intel_gt_suspend_late)
which is also where the gsc worker is flushed. This will also mean we don't need to
create intel_uc_suspend_prepare for new plumbing.

  reply	other threads:[~2023-08-15  0:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-02 23:34 [Intel-gfx] [PATCH v1 0/3] Resolve suspend-resume racing with GuC destroy-context-worker Alan Previn
2023-08-02 23:34 ` [Intel-gfx] [PATCH v1 1/3] drm/i915/guc: Flush context destruction worker at suspend Alan Previn
2023-08-07 17:52   ` Rodrigo Vivi
2023-08-09 21:09     ` Teres Alexis, Alan Previn
2023-08-15  0:49       ` Teres Alexis, Alan Previn [this message]
2023-08-02 23:35 ` [Intel-gfx] [PATCH v1 2/3] drm/i915/guc: Close deregister-context race against CT-loss Alan Previn
2023-08-10  3:39   ` Teres Alexis, Alan Previn
2023-08-02 23:35 ` [Intel-gfx] [PATCH v1 3/3] drm/i915/gt: Timeout when waiting for idle in suspending Alan Previn
2023-08-07 17:56   ` Rodrigo Vivi
2023-08-09 19:38     ` Teres Alexis, Alan Previn
2023-08-02 23:52 ` [Intel-gfx] [PATCH v1 0/3] Resolve suspend-resume racing with GuC destroy-context-worker Teres Alexis, Alan Previn
2023-08-03  0:10 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2023-08-03  0:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-08-03  5:41 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55de694c85fe97cb616682b97e76a4e36e5d1abf.camel@intel.com \
    --to=alan.previn.teres.alexis@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox