From: Michel Thierry <michel.thierry@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Remove wrong warning from i915_gem_context_clean
Date: Thu, 8 Oct 2015 16:12:31 +0100 [thread overview]
Message-ID: <561687DF.5010402@intel.com> (raw)
In-Reply-To: <1444315020-32033-1-git-send-email-tvrtko.ursulin@linux.intel.com>
On 10/8/2015 3:37 PM, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> commit e9f24d5fb7cf3628b195b18ff3ac4e37937ceeae
> Author: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Date: Mon Oct 5 13:26:36 2015 +0100
>
> drm/i915: Clean up associated VMAs on context destruction
>
> Introduced a wrong assumption that all contexts have a ppgtt
> instance. This is not true when full PPGTT is not active so
> remove the WARN_ON_ONCE from the context cleanup code.
Aliasing ppgtt? (for the record, I tried with enable_ppgtt=1 while
reviewing the patch and didn't see the warning... maybe I didn't try
hard enough).
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Michel Thierry <michel.thierry@intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem_context.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c
> index 680b4c9f6b73..8c688a5f1589 100644
> --- a/drivers/gpu/drm/i915/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/i915_gem_context.c
> @@ -138,7 +138,7 @@ static void i915_gem_context_clean(struct intel_context *ctx)
> struct i915_hw_ppgtt *ppgtt = ctx->ppgtt;
> struct i915_vma *vma, *next;
>
> - if (WARN_ON_ONCE(!ppgtt))
> + if (!ppgtt)
> return;
>
> WARN_ON(!list_empty(&ppgtt->base.active_list));
>
Reviewed-by: Michel Thierry <michel.thierry@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-10-08 15:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 14:37 [PATCH] drm/i915: Remove wrong warning from i915_gem_context_clean Tvrtko Ursulin
2015-10-08 15:12 ` Michel Thierry [this message]
2015-10-08 16:02 ` Chris Wilson
2015-10-09 8:19 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561687DF.5010402@intel.com \
--to=michel.thierry@intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox