public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Yu Dai <yu.dai@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, Peter Antoine <peter.antoine@intel.com>
Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org,
	dave.gordon@intel.com
Subject: Re: [PATCH 1/2] Revert "FROM_UPSTREAM [VPG]: drm/i915/kbl: drm/i915: Avoid GuC loading for now on Kabylake."
Date: Tue, 19 Jan 2016 14:38:00 -0800	[thread overview]
Message-ID: <569EBAC8.70402@intel.com> (raw)
In-Reply-To: <20160119212524.GW19130@phenom.ffwll.local>



On 01/19/2016 01:25 PM, Daniel Vetter wrote:
> On Tue, Jan 19, 2016 at 09:18:50PM +0000, Peter Antoine wrote:
> > This reverts commit a92d3f32eafc57cca55e654ecfd916f283100365.
>
> Shouldnt' this be patch 2/2? Enabling guc loading before it's fixed isn't
> awesome.
>
> Either way needs a proper commit message (why is it ok to enable now?)

This request was from Sean Kelley who is working on some Media features 
for KBL that relies on HuC firmware. HuC loading is done by GuC.

Thanks,
Alex

> > ---
> >  drivers/gpu/drm/i915/i915_drv.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> > index af30148..f99a988 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -2635,8 +2635,8 @@ struct drm_i915_cmd_table {
> >
> >  #define HAS_CSR(dev)	(IS_GEN9(dev))
> >
> > -#define HAS_GUC_UCODE(dev)	(IS_GEN9(dev) && !IS_KABYLAKE(dev))
> > -#define HAS_GUC_SCHED(dev)	(IS_GEN9(dev) && !IS_KABYLAKE(dev))
> > +#define HAS_GUC_UCODE(dev)	(IS_GEN9(dev))
> > +#define HAS_GUC_SCHED(dev)	(IS_GEN9(dev))
> >
> >  #define HAS_RESOURCE_STREAMER(dev) (IS_HASWELL(dev) || \
> >  				    INTEL_INFO(dev)->gen >= 8)
> > --
> > 1.9.1
> >
>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-01-19 22:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-19 21:18 [PATCH 0/2] Enable GuC Loading on Kabylake Peter Antoine
2016-01-19 21:18 ` [PATCH 1/2] Revert "FROM_UPSTREAM [VPG]: drm/i915/kbl: drm/i915: Avoid GuC loading for now on Kabylake." Peter Antoine
2016-01-19 21:25   ` Daniel Vetter
2016-01-19 22:38     ` Yu Dai [this message]
2016-01-19 21:18 ` [PATCH 2/2] i915/guc: Add Kabylake GuC Loading Peter Antoine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569EBAC8.70402@intel.com \
    --to=yu.dai@intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel@ffwll.ch \
    --cc=dave.gordon@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=peter.antoine@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox